Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2882153003: [turbofan] Fully reduce node in JSCallReducer::ReduceSpreadCall. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fully reduce node in JSCallReducer::ReduceSpreadCall. When turning a JSCallWithSpread into a JSCall or a JSConstructWithSpread into a JSConstruct, we need to (manually) invoke the JSCallReducer logic again on the changed node to make sure that optimizations that are now possible for the JSCall or JSConstruct operator are properly applied. BUG=v8:5932, v8:5895, v8:6344, v8:6399, v8:6400 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2882153003 Cr-Commit-Position: refs/heads/master@{#45325} Committed: https://chromium.googlesource.com/v8/v8/+/724d8dfe936a7dcaa4b9a7f13594849c2ccba209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/js-call-reducer.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-15 19:36:34 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-16 08:57:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882153003/1
3 years, 7 months ago (2017-05-16 09:00:32 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 09:02:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/724d8dfe936a7dcaa4b9a7f13594849c2cc...

Powered by Google App Engine
This is Rietveld 408576698