MD Settings: Improve Sync Page Enter key handling.

MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL

Review-Url: https://codereview.chromium.org/2882143003
Cr-Commit-Position: refs/heads/master@{#472163}
Committed: https://chromium.googlesource.com/chromium/src/+/7527494451ef6967ba4f39c657782b4babccbc7e

[tommycli, 2017-05-15 22:28:50]

Description was changed from

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
==========

to

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-05-15 22:28:54]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2017-05-15 22:29:09]

Description was changed from

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL
==========

[tommycli, 2017-05-15 22:29:09]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:30:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:10:09]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tommycli, 2017-05-15 23:11:15]

dbeam: PTAL, thanks!

[tommycli, 2017-05-15 23:11:20]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:12:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:17:38]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-16 02:20:57]

lgtm

https://codereview.chromium.org/2882143003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_page.js (right):

https://codereview.chromium.org/2882143003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_page.js:298: *           key:
(string|undefined)}} e
KeyboardEvent?

[tommycli, 2017-05-16 16:17:53]

thanks!

https://codereview.chromium.org/2882143003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_page.js (right):

https://codereview.chromium.org/2882143003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_page.js:298: *           key:
(string|undefined)}} e
On 2017/05/16 02:20:55, Dan Beam wrote:
> KeyboardEvent?

Done. I used Event because it could be a mouse event too.

[tommycli, 2017-05-16 16:17:56]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-05-16 16:17:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2882143003/#ps20001
(title: "fix type def")

[commit-bot: I haz the power, 2017-05-16 16:18:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:18:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494951476783140,
"parent_rev": "89689737e4beb0d37a4037215b3fd2b2bd32010d", "commit_rev":
"7527494451ef6967ba4f39c657782b4babccbc7e"}

[commit-bot: I haz the power, 2017-05-16 18:18:42]

Description was changed from

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL
==========

to

==========
MD Settings: Improve Sync Page Enter key handling.

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL

Review-Url: https://codereview.chromium.org/2882143003
Cr-Commit-Position: refs/heads/master@{#472163}
Committed:
https://chromium.googlesource.com/chromium/src/+/7527494451ef6967ba4f39c65778...
==========

[commit-bot: I haz the power, 2017-05-16 18:18:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7527494451ef6967ba4f39c65778...