Fix the bug that 'Afikaans' is unable to be selected in language menu.

Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can prevent the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages" on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
Review-Url: https://codereview.chromium.org/2882143002
Cr-Commit-Position: refs/heads/master@{#471990}
Committed: https://chromium.googlesource.com/chromium/src/+/6a55a101eb8e05a04285cfd416b6506d711a7d19

[Marti Wong, 2017-05-15 01:20:44]

martiw@chromium.org changed reviewers:
+ googleo@google.com, mdjones@chromium.org

[Marti Wong, 2017-05-15 01:20:44]

PTAL. thanks

[Marti Wong, 2017-05-15 01:25:04]

Description was changed from

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by doing the isEnabled() check for MENU_OVERFLOW
only. (but not for MENU_TARGET_LANGUAGE and MENU_SOURCE_LANGUAGE.)

BUG=721950
==========

to

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by doing the isEnabled() check for MENU_OVERFLOW
only. (but not for MENU_TARGET_LANGUAGE and MENU_SOURCE_LANGUAGE.)

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

[Marti Wong, 2017-05-15 01:25:42]

Description was changed from

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by doing the isEnabled() check for MENU_OVERFLOW
only. (but not for MENU_TARGET_LANGUAGE and MENU_SOURCE_LANGUAGE.)

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

to

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by doing the isEnabled() check for MENU_OVERFLOW
only. (but not for MENU_TARGET_LANGUAGE and MENU_SOURCE_LANGUAGE.)

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

[Marti Wong, 2017-05-15 03:51:12]

Description was changed from

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by doing the isEnabled() check for MENU_OVERFLOW
only. (but not for MENU_TARGET_LANGUAGE and MENU_SOURCE_LANGUAGE.)

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

to

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can preventing the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

[Marti Wong, 2017-05-15 03:54:02]

Patchset #1 (id:1) has been deleted

[mdjones, 2017-05-15 16:25:21]

Would it make more sense for ID_UNDEFINED to be a negative number so it never
collides with any valid item?

nit: "preventing" -> "prevent" in description.

[Marti Wong, 2017-05-15 23:46:12]

Description was changed from

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can preventing the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

to

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can prevent the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

[Marti Wong, 2017-05-16 00:21:02]

On 2017/05/15 16:25:21, mdjones wrote:
> Would it make more sense for ID_UNDEFINED to be a negative number so it never
> collides with any valid item?
> 
> nit: "preventing" -> "prevent" in description.

Thanks Matthew.
Yup. your way is simplier.
Done and PTAL again.

[mdjones, 2017-05-16 00:45:15]

lgtm

[mdjones, 2017-05-16 00:46:00]

On 2017/05/16 00:45:15, mdjones wrote:
> lgtm

Also update the description to match the solution.

[Marti Wong, 2017-05-16 00:46:02]

On 2017/05/16 00:45:15, mdjones wrote:
> lgtm

thanks Matthew!

[Marti Wong, 2017-05-16 00:46:06]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:47:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:42:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494895566409410,
"parent_rev": "2c74298547fc78cca48b66e917e0983dedacdbb4", "commit_rev":
"6a55a101eb8e05a04285cfd416b6506d711a7d19"}

[commit-bot: I haz the power, 2017-05-16 02:42:46]

Description was changed from

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can prevent the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950
==========

to

==========
Fix the bug that 'Afikaans' is unable to be selected in language menu.
It is because the item 'Afikaans' was mistakenly disabled in
TranslateMenuHelper#isEnabled() as its mId = TranslateMenu.ID_UNDEFINED.
This could be fixed by creating Id offsets for the menuItems of
different menus. (MENU_OVERFLOW, MENU_TARGET_LANGUAGE, MENU_SOURCE_LANGUAGE.)
This can prevent the menuItem's IDs of those menus from overlapping.
And make menu bugs in future easier to investigate and fix.

More info:
MENU_OVERFLOW is the menu which shows after clicking on the "3 dots" menu button
on the new translation infobar.

MENU_TARGET_LANGUAGE is the menu which shows after clicking on "More Languages"
on the overflow menu above.

MENU_SOURCE_LANGUAGE is the menu which shows after clicking on "Page not in this
language" on the overflow menu.

Prototype of the new translation infobar:
https://bbergher.googleplex.com/prototypes/translate/easier-1/


BUG=721950

Review-Url: https://codereview.chromium.org/2882143002
Cr-Commit-Position: refs/heads/master@{#471990}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a55a101eb8e05a04285cfd416b6...
==========

[commit-bot: I haz the power, 2017-05-16 02:42:47]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6a55a101eb8e05a04285cfd416b6...