Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2882133003: component_updater: add '_env_version' attribute for cros_component_installer (Closed)

Created:
3 years, 7 months ago by xiaochu
Modified:
3 years, 7 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

component_updater: add '_env_version' attribute for cros_component_installer Add _env_version attribute for each cros component update check. Remove dir field in configuration and use name to be dir name. BUG=chromium:690521 TEST=Run on a chromebook to download escpr successfully. Review-Url: https://codereview.chromium.org/2882133003 Cr-Commit-Position: refs/heads/master@{#472294} Committed: https://chromium.googlesource.com/chromium/src/+/abd733507c8848b6023fbd6e1c1ca5dbdddc60df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M chrome/browser/component_updater/cros_component_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/cros_component_installer.cc View 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
waffles
lgtm
3 years, 7 months ago (2017-05-16 16:47:35 UTC) #3
xiaochu
On 2017/05/16 16:47:35, waffles wrote: > lgtm thanks!
3 years, 7 months ago (2017-05-16 17:14:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882133003/1
3 years, 7 months ago (2017-05-17 02:35:37 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:43:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abd733507c8848b6023fbd6e1c1c...

Powered by Google App Engine
This is Rietveld 408576698