Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2882113004: [ObjC ARC] Converts ios/chrome/test/base:base to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by liaoyuke
Modified:
2 months, 1 week ago
Reviewers:
baxley
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/test/base:base to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2882113004 Cr-Commit-Position: refs/heads/master@{#472899} Committed: https://chromium.googlesource.com/chromium/src/+/07b6ee089c18c84e6dbd51d6ce04634b7103e3da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/test/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/base/scoped_block_swizzler.mm View 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:  linux_chromium_rel_ng   chromium_presubmit   linux_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   android_n5x_swarming_rel   cast_shell_android   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe   win_chromium_rel_ng   chromium_presubmit   win_chromium_rel_ng   win_chromium_rel_ng   chromium_presubmit   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   ios-simulator-xcode-clang   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   ios-device   ios-simulator   ios-device-xcode-clang   linux_chromium_compile_dbg_ng   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_n5x_swarming_rel   android_clang_dbg_recipe   android_cronet   android_compile_dbg   android_arm64_dbg_recipe   mac_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux 
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (14 generated)
liaoyuke
Hey Mike, PTAL! Thank you very much!
2 months, 1 week ago (2017-05-17 15:24:44 UTC) #6
baxley
lgtm
2 months, 1 week ago (2017-05-17 16:26:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882113004/1
2 months, 1 week ago (2017-05-17 16:34:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447296)
2 months, 1 week ago (2017-05-17 21:17:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882113004/1
2 months, 1 week ago (2017-05-17 23:05:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447906)
2 months, 1 week ago (2017-05-18 05:35:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882113004/1
2 months, 1 week ago (2017-05-18 15:30:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/459014)
2 months, 1 week ago (2017-05-18 18:25:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882113004/1
2 months, 1 week ago (2017-05-18 18:33:22 UTC) #21
commit-bot: I haz the power
2 months, 1 week ago (2017-05-18 19:25:57 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07b6ee089c18c84e6dbd51d6ce04...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973