Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2882113002: Make ESpeak an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ESpeak an enum class. This patch makes ESpeak an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2882113002 Cr-Commit-Position: refs/heads/master@{#471679} Committed: https://chromium.googlesource.com/chromium/src/+/fdfdd6c46acf0f4624c64b9e43623c422930423c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-14 23:13:38 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:22:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882113002/1
3 years, 7 months ago (2017-05-15 06:02:15 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 06:06:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdfdd6c46acf0f4624c64b9e4362...

Powered by Google App Engine
This is Rietveld 408576698