Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2882103002: Make ELineBreak an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ELineBreak an enum class. This patch makes ELineBreak an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2882103002 Cr-Commit-Position: refs/heads/master@{#471939} Committed: https://chromium.googlesource.com/chromium/src/+/cff8d177b5cbcbaabf7e9860576d2f629f94debb

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-14 23:06:13 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:23:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882103002/20001
3 years, 7 months ago (2017-05-15 22:47:00 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 22:59:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cff8d177b5cbcbaabf7e9860576d...

Powered by Google App Engine
This is Rietveld 408576698