Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2882093002: Make EUserSelect an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EUserSelect an enum class. This patch makes EUserSelect an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2882093002 Cr-Commit-Position: refs/heads/master@{#472975} Committed: https://chromium.googlesource.com/chromium/src/+/385931fbf1990470dde91e5f12c75db5680193c4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Messages

Total messages: 38 (34 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-14 22:55:42 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:24:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882093002/60001
3 years, 7 months ago (2017-05-18 23:35:16 UTC) #34
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 23:45:36 UTC) #38
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/385931fbf1990470dde91e5f12c7...

Powered by Google App Engine
This is Rietveld 408576698