Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2882013002: Add experiment for having a "Beta forum" link in the help menu. (Closed)

Created:
3 years, 7 months ago by Bret
Modified:
3 years, 7 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add experiment for having a "Beta forum" link in the help menu. BUG=706105 R=holte@chromium.org, jcivelli@chromium.org, pkasting@chromium.org Review-Url: https://codereview.chromium.org/2882013002 . Cr-Commit-Position: refs/heads/master@{#472936} Committed: https://chromium.googlesource.com/chromium/src/+/2d018660e03ccf72bc3343aabb81a1f57face279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
Bret
jcivelli: chrome/app/* pkasting: chrome/browser/ui/* holte: histograms.xml PTAL!
3 years, 7 months ago (2017-05-13 22:51:11 UTC) #3
Jay Civelli
LGTM for chrome/app
3 years, 7 months ago (2017-05-15 16:16:57 UTC) #8
Peter Kasting
c/b/ui/ LGTM
3 years, 7 months ago (2017-05-15 16:55:08 UTC) #9
Steven Holte
histograms lgtm
3 years, 7 months ago (2017-05-16 00:05:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882013002/1
3 years, 7 months ago (2017-05-16 18:29:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/295280)
3 years, 7 months ago (2017-05-16 20:22:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882013002/1
3 years, 7 months ago (2017-05-16 20:29:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/428370)
3 years, 7 months ago (2017-05-17 04:19:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882013002/1
3 years, 7 months ago (2017-05-17 18:39:36 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447837)
3 years, 7 months ago (2017-05-18 02:48:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882013002/1
3 years, 7 months ago (2017-05-18 18:42:28 UTC) #24
Bret
3 years, 7 months ago (2017-05-18 21:32:31 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d018660e03ccf72bc3343aabb81a1f57face279 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698