Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2881933003: Store NavigationItem's unique ID in navigation context. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Store NavigationItem's unique ID in navigation context. This allows to correctly commit non-latest pending navigation in webView:didCommitNavigation: BUG=712269 Review-Url: https://codereview.chromium.org/2881933003 Cr-Commit-Position: refs/heads/master@{#471905} Committed: https://chromium.googlesource.com/chromium/src/+/1f66b4a55804cd494ec380c0a08446656ce512b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M ios/web/web_state/navigation_context_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-13 00:25:12 UTC) #6
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-15 20:39:12 UTC) #7
Eugene But (OOO till 7-30)
Thanks!
3 years, 7 months ago (2017-05-15 21:03:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881933003/1
3 years, 7 months ago (2017-05-15 21:04:50 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 21:23:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f66b4a55804cd494ec380c0a084...

Powered by Google App Engine
This is Rietveld 408576698