Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2881793003:
[Devtools] Updated frontend version to 24 - remove products column (Closed)
|
Created:
3 years, 7 months ago by allada Modified:
3 years, 7 months ago Reviewers:
pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Updated frontend version to 24 - remove products column
See title.
BUG=
Review-Url: https://codereview.chromium.org/2881793003
Cr-Commit-Position: refs/heads/master@{#472617}
Committed: https://chromium.googlesource.com/chromium/src/+/02582585906bf67195c50330ffef797fb2f7ce59
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
Description was changed from ========== [Devtools] Updated frontend version to 24 - remove products column See title. BUG= ========== to ========== [Devtools] Updated frontend version to 24 - remove products column See title. BUG= ==========
allada@chromium.org changed reviewers: + pfeldman@chromium.org
lgtm
The CQ bit was checked by pfeldman@chromium.org
lgtm
Please follow up with the refactoring that splits visibility settings from custom column settings.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495065829921430, "parent_rev":
"c4f60b915d897050dac3d7532ff8c1e0139c1821", "commit_rev":
"02582585906bf67195c50330ffef797fb2f7ce59"}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Updated frontend version to 24 - remove products column See title. BUG= ========== to ========== [Devtools] Updated frontend version to 24 - remove products column See title. BUG= Review-Url: https://codereview.chromium.org/2881793003 Cr-Commit-Position: refs/heads/master@{#472617} Committed: https://chromium.googlesource.com/chromium/src/+/02582585906bf67195c50330ffef... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/02582585906bf67195c50330ffef... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
