Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2881763003:
[array] Simplify index calculation in Array.p.indexOf (Closed)
Description[array] Simplify index calculation in Array.p.indexOf
No semantic changes, just a readability refactoring that removes
a couple of unnecessary variables and labels.
BUG=v8:6371
Review-Url: https://codereview.chromium.org/2881763003
Cr-Commit-Position: refs/heads/master@{#45290}
Committed: https://chromium.googlesource.com/v8/v8/+/e658bc575faa091c570a652b240e1da3866ee5c7
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rebase and address comments #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Simplify index calculation BUG= ========== to ========== [array] Simplify index calculation in Array.p.indexOf No semantic changes, just a readability refactoring that removes a couple of unnecessary variables and labels. BUG=v8:6371 ==========
jgruber@chromium.org changed reviewers: + cbruni@chromium.org, mattloring@google.com
lgtm https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... File src/builtins/builtins-array-gen.cc (right): https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... src/builtins/builtins-array-gen.cc:1679: BIND(&init_k); nit: init_index https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... src/builtins/builtins-array-gen.cc:1892: args.GetOptionalArgumentValue(kFromIndexArg, UndefinedConstant()); we should make this the default probably at some point.
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... File src/builtins/builtins-array-gen.cc (right): https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... src/builtins/builtins-array-gen.cc:1679: BIND(&init_k); On 2017/05/15 07:15:41, Camillo Bruni wrote: > nit: init_index Done. https://codereview.chromium.org/2881763003/diff/1/src/builtins/builtins-array... src/builtins/builtins-array-gen.cc:1892: args.GetOptionalArgumentValue(kFromIndexArg, UndefinedConstant()); On 2017/05/15 07:15:41, Camillo Bruni wrote: > we should make this the default probably at some point. Acknowledged.
The CQ bit was unchecked by jgruber@chromium.org
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org Link to the patchset: https://codereview.chromium.org/2881763003/#ps20001 (title: "Rebase and address comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494835301867120,
"parent_rev": "f0082e563169f9e812d37a349d0d250d0777e1ad", "commit_rev":
"dca8831a39d9a45e7115c795f71566b8de9b221f"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494835301867120,
"parent_rev": "6c75e145ec58d63a1f9f426a934d7298c4f96783", "commit_rev":
"e658bc575faa091c570a652b240e1da3866ee5c7"}
Message was sent while issue was closed.
Description was changed from ========== [array] Simplify index calculation in Array.p.indexOf No semantic changes, just a readability refactoring that removes a couple of unnecessary variables and labels. BUG=v8:6371 ========== to ========== [array] Simplify index calculation in Array.p.indexOf No semantic changes, just a readability refactoring that removes a couple of unnecessary variables and labels. BUG=v8:6371 Review-Url: https://codereview.chromium.org/2881763003 Cr-Commit-Position: refs/heads/master@{#45290} Committed: https://chromium.googlesource.com/v8/v8/+/e658bc575faa091c570a652b240e1da3866... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/e658bc575faa091c570a652b240e1da3866... |
