DevTools: Colorize more types in JS syntax highlighting

DevTools: Colorize more types in JS syntax highlighting

BUG=721986
Review-Url: https://codereview.chromium.org/2881753003
Cr-Commit-Position: refs/heads/master@{#471562}
Committed: https://chromium.googlesource.com/chromium/src/+/165ea5770f4a008b149dec4706989344d6a61803

[paulirish, 2017-05-13 02:30:47]

Description was changed from

==========
DevTools: Colorize more types in JS syntax highlighting
==========

to

==========
DevTools: Colorize more types in JS syntax highlighting

BUG=721986
==========

[paulirish, 2017-05-13 02:32:19]

paulirish@chromium.org changed reviewers:
+ lushnikov@chromium.org

[paulirish, 2017-05-13 02:32:20]

I kept the coloring pretty conservative. There are two more classes which are
still available to color but I'd let them fall-through to black.
(.cm-js-property, cm-js-variable)

Screenshots in http://imgur.com/a/9QPS2 and on the bug.

PTAL

[paulirish, 2017-05-13 02:59:19]

updated w/ our adjustments.

[lushnikov, 2017-05-13 03:29:32]

lgtm

[paulirish, 2017-05-13 03:37:32]

The CQ bit was checked by paulirish@chromium.org

[commit-bot: I haz the power, 2017-05-13 03:37:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 05:15:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494646652793620,
"parent_rev": "e7af900149e7cf53a08d95b0ab69e05a6bd48b66", "commit_rev":
"165ea5770f4a008b149dec4706989344d6a61803"}

[commit-bot: I haz the power, 2017-05-13 05:16:02]

Description was changed from

==========
DevTools: Colorize more types in JS syntax highlighting

BUG=721986
==========

to

==========
DevTools: Colorize more types in JS syntax highlighting

BUG=721986

Review-Url: https://codereview.chromium.org/2881753003
Cr-Commit-Position: refs/heads/master@{#471562}
Committed:
https://chromium.googlesource.com/chromium/src/+/165ea5770f4a008b149dec470698...
==========

[commit-bot: I haz the power, 2017-05-13 05:16:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/165ea5770f4a008b149dec470698...

[dgozman, 2017-05-15 17:14:14]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-05-15 17:14:15]

I'm not sure the new coloring scheme is very good:
- why assignments are green, similar to global(?) variables?
- why my variable foo is blue in one place, and black in another?
- what's so special in the work "Bindings", so that it's green in
"Bindings.breakpointManager"?