Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2881753003: DevTools: Colorize more types in JS syntax highlighting (Closed)

Created:
3 years, 7 months ago by paulirish
Modified:
3 years, 7 months ago
Reviewers:
dgozman, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Colorize more types in JS syntax highlighting BUG=721986 Review-Url: https://codereview.chromium.org/2881753003 Cr-Commit-Position: refs/heads/master@{#471562} Committed: https://chromium.googlesource.com/chromium/src/+/165ea5770f4a008b149dec4706989344d6a61803

Patch Set 1 #

Patch Set 2 : tweaks. no more aquamarine on vars. now highlight globals. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
paulirish
I kept the coloring pretty conservative. There are two more classes which are still available ...
3 years, 7 months ago (2017-05-13 02:32:20 UTC) #3
paulirish
updated w/ our adjustments.
3 years, 7 months ago (2017-05-13 02:59:19 UTC) #4
lushnikov
lgtm
3 years, 7 months ago (2017-05-13 03:29:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881753003/20001
3 years, 7 months ago (2017-05-13 03:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/165ea5770f4a008b149dec4706989344d6a61803
3 years, 7 months ago (2017-05-13 05:16:03 UTC) #10
dgozman
3 years, 7 months ago (2017-05-15 17:14:15 UTC) #12
Message was sent while issue was closed.
I'm not sure the new coloring scheme is very good:
- why assignments are green, similar to global(?) variables?
- why my variable foo is blue in one place, and black in another?
- what's so special in the work "Bindings", so that it's green in
"Bindings.breakpointManager"?

Powered by Google App Engine
This is Rietveld 408576698