Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2881753002: TopSites: various small cleanups (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TopSites: various small cleanups - Update some comments. - Replace some iterators with range-based fors. - Add some "const"s. - etc BUG=718413 Review-Url: https://codereview.chromium.org/2881753002 Cr-Commit-Position: refs/heads/master@{#471748} Committed: https://chromium.googlesource.com/chromium/src/+/481b55a2fa48d01f9c8357dd8aad039ffaf90f69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -76 lines) Patch
M chrome/browser/search/thumbnail_source.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/history/core/browser/top_sites.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/history/core/browser/top_sites_cache.h View 2 chunks +3 lines, -6 lines 0 comments Download
M components/history/core/browser/top_sites_impl.h View 8 chunks +13 lines, -16 lines 0 comments Download
M components/history/core/browser/top_sites_impl.cc View 16 chunks +41 lines, -48 lines 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Marc Treib
A bunch of small things I noticed while reading the code. PTAL!
3 years, 7 months ago (2017-05-12 13:07:09 UTC) #7
sdefresne
lgtm
3 years, 7 months ago (2017-05-15 13:01:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881753002/1
3 years, 7 months ago (2017-05-15 13:05:40 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 13:54:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/481b55a2fa48d01f9c8357dd8aad...

Powered by Google App Engine
This is Rietveld 408576698