third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html - Issue 2881743002: [ServiceWorker] Revise wpt tests for Client.type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

Issue 2881743002: [ServiceWorker] Revise wpt tests for Client.type (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html ('k') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-exact-controller.https.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

index 45da2b35eff06d35169b0191b3f30d5bb60b2a3f..3cb1270fe16213f3515a54a5660441091a243b42 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html

@@ -60,9 +60,9 @@ function wait_for_clientId() {

}

var expected = [

- /* visibilityState, focused, url, frameType */

- ['visible', true, normalizeURL(scope) + '#1', 'nested'],

- ['visible', false, normalizeURL(scope) + '#2', 'nested'],

+ /* visibilityState, focused, url, type, frameType */

falken 2017/05/15 06:39:28 nit: comment style

leonhsl(Using Gerrit) 2017/05/16 02:54:28 Done.

+ ['visible', true, normalizeURL(scope) + '#1', 'window', 'nested'],

+ ['visible', false, normalizeURL(scope) + '#2', 'window', 'nested'],

undefined

];

</script>