Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2881733002: Add COMPONENT annotation to net/nqe/ OWNERS file (Closed)

Created:
3 years, 7 months ago by tbansal1
Modified:
3 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add COMPONENT annotation to net/nqe/ OWNERS file Also, minor updates to net/OWNERS file: Remove owners for deprecated gyp files, and update owners for GN files. Review-Url: https://codereview.chromium.org/2881733002 Cr-Commit-Position: refs/heads/master@{#471405} Committed: https://chromium.googlesource.com/chromium/src/+/0895bf265a7dc57594483ebc6492de43d272bd31

Patch Set 1 : ps #

Total comments: 2

Patch Set 2 : mmenke comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
M net/nqe/OWNERS View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
tbansal1
mmenke: ptal at *. Thanks.
3 years, 7 months ago (2017-05-12 17:59:31 UTC) #4
mmenke
LGTM https://codereview.chromium.org/2881733002/diff/20001/net/nqe/OWNERS File net/nqe/OWNERS (right): https://codereview.chromium.org/2881733002/diff/20001/net/nqe/OWNERS#newcode5 net/nqe/OWNERS:5: # COMPONENT: Internals>Network>NetworkQuality optional: Is there a team ...
3 years, 7 months ago (2017-05-12 18:03:30 UTC) #5
tbansal1
https://codereview.chromium.org/2881733002/diff/20001/net/nqe/OWNERS File net/nqe/OWNERS (right): https://codereview.chromium.org/2881733002/diff/20001/net/nqe/OWNERS#newcode5 net/nqe/OWNERS:5: # COMPONENT: Internals>Network>NetworkQuality On 2017/05/12 18:03:29, mmenke wrote: > ...
3 years, 7 months ago (2017-05-12 18:12:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881733002/40001
3 years, 7 months ago (2017-05-12 19:10:47 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 19:23:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0895bf265a7dc57594483ebc6492...

Powered by Google App Engine
This is Rietveld 408576698