Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2881693002: Move more classes to WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken, kinuko, tkent
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more classes to WebLocalFrameBase instead of WebLocalFrameImpl. This CL uses WebLocalFrameBase to break dependencies on WebLocalFrameImpl at the web/ layer. In some case, methods have been made pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl to assist with the decoupling. We need to break these dependencies so we can Move WebLocalFrameImpl to core. This CL updates: - TextFinder - WebEmbeddedWorkerImpl - WebFrameSerializer - WebFrameSerializerImpl - WebSharedWorkerImpl BUG=708879 Review-Url: https://codereview.chromium.org/2881693002 Cr-Commit-Position: refs/heads/master@{#471308} Committed: https://chromium.googlesource.com/chromium/src/+/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -39 lines) Patch
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebScopedUserGesture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
slangley
3 years, 7 months ago (2017-05-12 04:19:55 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-12 04:37:07 UTC) #5
kinuko
(lgtm/2)
3 years, 7 months ago (2017-05-12 04:58:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881693002/1
3 years, 7 months ago (2017-05-12 05:33:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/382779)
3 years, 7 months ago (2017-05-12 06:32:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881693002/1
3 years, 7 months ago (2017-05-12 10:37:00 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 15:38:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee9b642ef6c3c43f8342cd3522a1...

Powered by Google App Engine
This is Rietveld 408576698