Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: content/public/common/common_param_traits.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)
Patch Set: More fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/common_param_traits.cc
diff --git a/content/public/common/common_param_traits.cc b/content/public/common/common_param_traits.cc
index 286e6621cc6212cf727ba636c44d4df4a0ba6ceb..d11e66c8cd57715095feb22d9fc2224cd34c6d66 100644
--- a/content/public/common/common_param_traits.cc
+++ b/content/public/common/common_param_traits.cc
@@ -124,11 +124,11 @@ void ParamTraits<net::IPEndPoint>::Log(const param_type& p, std::string* l) {
void ParamTraits<net::IPAddress>::GetSize(base::PickleSizer* s,
const param_type& p) {
- GetParamSize(s, p.bytes());
+ GetParamSize(s, p.BytesAsVector());
eroman 2017/05/12 23:25:04 Can you improve the efficiency of this? (Construct
Ryan Hamilton 2017/05/13 13:20:46 Good point. Done.
}
void ParamTraits<net::IPAddress>::Write(base::Pickle* m, const param_type& p) {
- WriteParam(m, p.bytes());
+ WriteParam(m, p.BytesAsVector());
eroman 2017/05/12 23:25:04 Same here.
Ryan Hamilton 2017/05/13 13:20:46 Done.
}
bool ParamTraits<net::IPAddress>::Read(const base::Pickle* m,

Powered by Google App Engine
This is Rietveld 408576698