Avoid heap allocations in IPAddress

content/public/common/common_param_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/common_param_traits.h"
 
 #include <string>
 
 #include "content/public/common/content_constants.h"
 #include "content/public/common/page_state.h"
@@ skipping 106 matching lines @@
   *p = net::IPEndPoint(address, port);
   return true;
 }
 
 void ParamTraits<net::IPEndPoint>::Log(const param_type& p, std::string* l) {
   LogParam("IPEndPoint:" + p.ToString(), l);
 }
 
 void ParamTraits<net::IPAddress>::GetSize(base::PickleSizer* s,
                                           const param_type& p) {
-  GetParamSize(s, p.bytes());
+  GetParamSize(s, p.BytesAsVector());

[eroman, 2017/05/12 23:25:04]

Can you improve the efficiency of this?
(Constructs a temporary vector, only to get the size).

[Ryan Hamilton, 2017/05/13 13:20:46]

Good point. Done.

 }
 
 void ParamTraits<net::IPAddress>::Write(base::Pickle* m, const param_type& p) {
-  WriteParam(m, p.bytes());
+  WriteParam(m, p.BytesAsVector());

[eroman, 2017/05/12 23:25:04]

Same here.

[Ryan Hamilton, 2017/05/13 13:20:46]

Done.

 }
 
 bool ParamTraits<net::IPAddress>::Read(const base::Pickle* m,
                                        base::PickleIterator* iter,
                                        param_type* p) {
   std::vector<uint8_t> bytes;
   if (!ReadParam(m, iter, &bytes))
     return false;
   if (bytes.size() &&
       bytes.size() != net::IPAddress::kIPv4AddressSize &&
@@ skipping 57 matching lines @@
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC
 
 // Generate param traits log methods.
 #include "ipc/param_traits_log_macros.h"
 namespace IPC {
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC