[Sync] Alphabetize proto conversion files.

[Sync] Alphabetize proto conversion files.

BUG=

Review-Url: https://codereview.chromium.org/2881603005
Cr-Commit-Position: refs/heads/master@{#471934}
Committed: https://chromium.googlesource.com/chromium/src/+/d609cd24c3e263dfc5a0b11970af1b23c0620dae

[skym, 2017-05-12 22:55:15]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-05-12 22:55:26]

Description was changed from

==========
[Sync] Alphabetize proto conversion files.

BUG=
==========

to

==========
[Sync] Alphabetize proto conversion files.

BUG=
==========

[skym, 2017-05-12 22:55:26]

skym@chromium.org changed reviewers:
+ pnoland@chromium.org

[skym, 2017-05-12 22:55:33]

PTAL

[commit-bot: I haz the power, 2017-05-12 22:56:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2017-05-12 23:21:27]

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_value_conversions.h (right):

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_value_conversions.h:270:
std::unique_ptr<base::DictionaryValue> ClientToServerMessageToValue(
I'm assuming these three(ClientToServerMessageToValue,
ClientToServerResponseToValue, SyncEntityToValue) are out of order because they
don't correspond to an actual modeltype? Is that enough of a distinction to
warrant not alphabetizing them?

[commit-bot: I haz the power, 2017-05-13 01:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 01:03:04]

Dry run: This issue passed the CQ dry run.

[skym, 2017-05-15 15:01:36]

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_value_conversions.h (right):

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_value_conversions.h:270:
std::unique_ptr<base::DictionaryValue> ClientToServerMessageToValue(
On 2017/05/12 23:21:27, Patrick Noland wrote:
> I'm assuming these three(ClientToServerMessageToValue,
> ClientToServerResponseToValue, SyncEntityToValue) are out of order because
they
> don't correspond to an actual modeltype? Is that enough of a distinction to
> warrant not alphabetizing them?

In addition to alphabetizing, I wanted to make sure cc and h files match in
order, which is what my changes here do. If you look at the cc file, these
functions are created from a macro, and interleaving these three functions would
look odd.

[Patrick Noland, 2017-05-15 20:00:22]

lgtm

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_value_conversions.h (right):

https://codereview.chromium.org/2881603005/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_value_conversions.h:270:
std::unique_ptr<base::DictionaryValue> ClientToServerMessageToValue(
On 2017/05/15 15:01:36, skym wrote:
> On 2017/05/12 23:21:27, Patrick Noland wrote:
> > I'm assuming these three(ClientToServerMessageToValue,
> > ClientToServerResponseToValue, SyncEntityToValue) are out of order because
> they
> > don't correspond to an actual modeltype? Is that enough of a distinction to
> > warrant not alphabetizing them?
> 
> In addition to alphabetizing, I wanted to make sure cc and h files match in
> order, which is what my changes here do. If you look at the cc file, these
> functions are created from a macro, and interleaving these three functions
would
> look odd.

Alright, can you add a comment explaining this for future readers t so that they
know how to keep things in order?

[skym, 2017-05-15 21:04:44]

Updates for Patrick.

[skym, 2017-05-15 21:04:48]

The CQ bit was checked by skym@chromium.org

[skym, 2017-05-15 21:04:48]

The patchset sent to the CQ was uploaded after l-g-t-m from pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2881603005/#ps20001
(title: "[Sync] Alphabetize proto conversion files.")

[commit-bot: I haz the power, 2017-05-15 21:05:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:51:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494882288291720,
"parent_rev": "3a2590571a2bd728532c61d46ce5df3dca09cb91", "commit_rev":
"d609cd24c3e263dfc5a0b11970af1b23c0620dae"}

[commit-bot: I haz the power, 2017-05-15 22:51:17]

Description was changed from

==========
[Sync] Alphabetize proto conversion files.

BUG=
==========

to

==========
[Sync] Alphabetize proto conversion files.

BUG=

Review-Url: https://codereview.chromium.org/2881603005
Cr-Commit-Position: refs/heads/master@{#471934}
Committed:
https://chromium.googlesource.com/chromium/src/+/d609cd24c3e263dfc5a0b11970af...
==========

[commit-bot: I haz the power, 2017-05-15 22:51:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d609cd24c3e263dfc5a0b11970af...