Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2881563004: Clear the cached avatar button offset when the DPI scaling changes (Closed)

Created:
3 years, 7 months ago by kylix_rd
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Listen to the Windows DPI scaling change message and force the user-avatar offset position to be recalculated. BUG=609398 Review-Url: https://codereview.chromium.org/2881563004 Cr-Commit-Position: refs/heads/master@{#472100} Committed: https://chromium.googlesource.com/chromium/src/+/0fe78b97dbbd03e9e08d676085f80a991d767d1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/minimize_button_metrics_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kylix_rd
In theory, this patch should work. I've not been able to properly test this since ...
3 years, 7 months ago (2017-05-12 16:02:23 UTC) #5
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-12 21:06:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881563004/1
3 years, 7 months ago (2017-05-16 13:55:09 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 14:38:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fe78b97dbbd03e9e08d676085f8...

Powered by Google App Engine
This is Rietveld 408576698