supersize: Make Disassemble() work for downloaded .size files

supersize: Make Disassemble() work for downloaded .size files

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also: 
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182
Review-Url: https://codereview.chromium.org/2881563003
Cr-Commit-Position: refs/heads/master@{#471165}
Committed: https://chromium.googlesource.com/chromium/src/+/1fa69f3de6a2dc4515c55333c30e2f0284f9ac4c

[agrieve, 2017-05-11 19:46:04]

Description was changed from

==========
supersize: Make Disassemble() work for downloaded .size files

* Store the toolchain prefix in metadata
* Pass --prefix and --prefix-strip to objdump

BUG=695182
==========

to

==========
supersize: Make Disassemble() work for downloaded .size files

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also: 
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182
==========

[agrieve, 2017-05-11 19:46:04]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-05-11 19:46:23]

On 2017/05/11 19:46:04, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🐝

[estevenson, 2017-05-11 21:02:17]

This lgtm, but I ran into problems running it locally. Should this have worked
or am I doing it wrong? 

>>> Disassemble(size_info.symbols.WhereInSection('t')[200])
/usr/bin/objdump: can't disassemble for architecture UNKNOWN!

Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File
"/usr/local/google/code/clankium/src/tools/binary_size/libsupersize/console.py",
line 211, in _DisassembleFunc
    prefix_len = self._DetectDisassemblePrefixLen(args)
  File
"/usr/local/google/code/clankium/src/tools/binary_size/libsupersize/console.py",
line 180, in _DetectDisassemblePrefixLen
    output = subprocess.check_output(args)
  File "/usr/lib/pypy/lib-python/2.7/subprocess.py", line 544, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['/usr/bin/objdump', '--disassemble', '--source',
'--line-numbers', '--demangle', '--start-address=0x2e29c4',
'--stop-address=0x2e2a28',
u'binary-size-bloat/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/libmonochrome.so']'
returned non-zero exit status 1

https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/integration_test.py (right):

https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/integration_test.py:89: maxDiff = None  # Don't
trucate diffs in errors.
unused?

[agrieve, 2017-05-12 01:19:06]

On 2017/05/11 21:02:17, estevenson wrote:
> This lgtm, but I ran into problems running it locally. Should this have worked
> or am I doing it wrong? 
> 
> >>> Disassemble(size_info.symbols.WhereInSection('t')[200])
> /usr/bin/objdump: can't disassemble for architecture UNKNOWN!
> 
> Traceback (most recent call last):
>   File "<console>", line 1, in <module>
>   File
>
"/usr/local/google/code/clankium/src/tools/binary_size/libsupersize/console.py",
> line 211, in _DisassembleFunc
>     prefix_len = self._DetectDisassemblePrefixLen(args)
>   File
>
"/usr/local/google/code/clankium/src/tools/binary_size/libsupersize/console.py",
> line 180, in _DetectDisassemblePrefixLen
>     output = subprocess.check_output(args)
>   File "/usr/lib/pypy/lib-python/2.7/subprocess.py", line 544, in check_output
>     raise CalledProcessError(retcode, cmd, output=output)
> CalledProcessError: Command '['/usr/bin/objdump', '--disassemble', '--source',
> '--line-numbers', '--demangle', '--start-address=0x2e29c4',
> '--stop-address=0x2e2a28',
>
u'binary-size-bloat/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/libmonochrome.so']'
> returned non-zero exit status 1
> 
>
https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
> File tools/binary_size/libsupersize/integration_test.py (right):
> 
>
https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
> tools/binary_size/libsupersize/integration_test.py:89: maxDiff = None  # Don't
> trucate diffs in errors.
> unused?

That's the error that you'd get if your tool-prefix is wrong, and it's using the
default one for x86 on an arm binary. Once the .size file start storing the
tool-prefix in the metadata, this should "just work".

[agrieve, 2017-05-12 01:19:16]

https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
File tools/binary_size/libsupersize/integration_test.py (right):

https://codereview.chromium.org/2881563003/diff/20001/tools/binary_size/libsu...
tools/binary_size/libsupersize/integration_test.py:89: maxDiff = None  # Don't
trucate diffs in errors.
On 2017/05/11 21:02:17, estevenson wrote:
> unused?

Used by the test framework.

[agrieve, 2017-05-12 01:19:20]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-05-12 01:19:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 01:33:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494551960544610,
"parent_rev": "84b6a842c0d92a52a557dbe102a9787999dfff21", "commit_rev":
"1fa69f3de6a2dc4515c55333c30e2f0284f9ac4c"}

[commit-bot: I haz the power, 2017-05-12 01:34:15]

Description was changed from

==========
supersize: Make Disassemble() work for downloaded .size files

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also: 
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182
==========

to

==========
supersize: Make Disassemble() work for downloaded .size files

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also: 
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182

Review-Url: https://codereview.chromium.org/2881563003
Cr-Commit-Position: refs/heads/master@{#471165}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fa69f3de6a2dc4515c55333c30e...
==========

[commit-bot: I haz the power, 2017-05-12 01:34:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fa69f3de6a2dc4515c55333c30e...