Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2881553003: [DevTools] Show scrollbars on chrome://inspect (Closed)

Created:
3 years, 7 months ago by eostroukhov
Modified:
3 years, 7 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Show scrollbars on chrome://inspect BUG=708903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881553003 Cr-Commit-Position: refs/heads/master@{#471500} Committed: https://chromium.googlesource.com/chromium/src/+/c2c2f1e158ff023cfac05e72160fa89d6228fc3b

Patch Set 1 #

Patch Set 2 : [DevTools] Show scrollbars on chrome://inspect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M chrome/browser/resources/inspect/inspect.css View 1 5 chunks +12 lines, -23 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
eostroukhov
I did an extensive manual testing to ensure there's no regressions on the page, including ...
3 years, 7 months ago (2017-05-11 23:58:20 UTC) #3
dgozman
Let's make the whole page scrollable, similar to chrome://extensions.
3 years, 7 months ago (2017-05-12 00:10:15 UTC) #6
eostroukhov
On 2017/05/12 00:10:15, dgozman wrote: > Let's make the whole page scrollable, similar to chrome://extensions. ...
3 years, 7 months ago (2017-05-12 20:46:56 UTC) #10
dgozman
lgtm
3 years, 7 months ago (2017-05-12 20:58:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881553003/20001
3 years, 7 months ago (2017-05-12 20:59:42 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 00:04:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2c2f1e158ff023cfac05e72160f...

Powered by Google App Engine
This is Rietveld 408576698