Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 288153002: Cleanup: Mark more string resources as platform-specific or remove them if they are unused. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, rpop
Visibility:
Public.

Description

Cleanup: Mark more string resources as platform-specific or remove them if they are unused. BUG=314805 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271841

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add back IDS_ABOUT_VERSION_LICENSE_EULA, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -188 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 13 chunks +99 lines, -94 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 13 chunks +99 lines, -94 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-15 06:05:38 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 7 months ago (2014-05-15 14:48:46 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-15 18:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/288153002/1
6 years, 7 months ago (2014-05-15 18:59:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 22:33:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 22:38:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/142973)
6 years, 7 months ago (2014-05-15 22:38:49 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-20 04:51:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/288153002/20001
6 years, 7 months ago (2014-05-20 04:51:25 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 06:35:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 07:11:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155286)
6 years, 7 months ago (2014-05-20 07:11:25 UTC) #12
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-20 07:12:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/288153002/20001
6 years, 7 months ago (2014-05-20 07:12:56 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 10:06:12 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 10:57:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28823)
6 years, 7 months ago (2014-05-20 10:57:31 UTC) #17
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-20 21:05:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/288153002/40001
6 years, 7 months ago (2014-05-20 21:08:05 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 00:33:27 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 01:05:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7225)
6 years, 7 months ago (2014-05-21 01:05:14 UTC) #22
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-21 02:13:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/288153002/40001
6 years, 7 months ago (2014-05-21 02:14:43 UTC) #24
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 03:22:17 UTC) #25
Message was sent while issue was closed.
Change committed as 271841

Powered by Google App Engine
This is Rietveld 408576698