Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 2881523002: Closure: convert the rest of chrome/browser/resources/ to v2 GYP (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, dbeam+watch-closure_chromium.org, dbeam+watch-ntp_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: convert the rest of chrome/browser/resources/ to v2 GYP R=dpapad@chromium.org BUG=585553 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881523002 Cr-Commit-Position: refs/heads/master@{#472236} Committed: https://chromium.googlesource.com/chromium/src/+/63a028cbc670c8aa4ca59c1ec56b14b22d433ebb

Patch Set 1 : logic fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -142 lines) Patch
D chrome/browser/resources/chromeos/compiled_resources.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
A chrome/browser/resources/chromeos/compiled_resources2.gyp View 1 chunk +195 lines, -0 lines 0 comments Download
D chrome/browser/resources/help/compiled_resources.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
A chrome/browser/resources/help/compiled_resources2.gyp View 1 chunk +102 lines, -0 lines 0 comments Download
D chrome/browser/resources/options/compiled_resources.gyp View 1 chunk +0 lines, -75 lines 0 comments Download
A chrome/browser/resources/options/compiled_resources2.gyp View 1 chunk +100 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compile2.py View 6 chunks +13 lines, -4 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Dan Beam
this relies on a bunch of other CLs, but you get the picture...
3 years, 7 months ago (2017-05-11 05:05:50 UTC) #4
Dan Beam
On 2017/05/11 05:05:50, Dan Beam wrote: > this relies on a bunch of other CLs, ...
3 years, 7 months ago (2017-05-16 04:08:35 UTC) #6
dpapad
LGTM
3 years, 7 months ago (2017-05-16 17:14:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881523002/60001
3 years, 7 months ago (2017-05-16 22:44:06 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:54:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/63a028cbc670c8aa4ca59c1ec56b...

Powered by Google App Engine
This is Rietveld 408576698