DevTools: Convert Security Panel to Sentence case

DevTools: Convert Security Panel to Sentence case

Replace use of Title Case in the Developer Tools' Security Panel to use sentence case, matching Chrome text standards.

BUG=721176
Review-Url: https://codereview.chromium.org/2881513003
Cr-Commit-Position: refs/heads/master@{#473435}
Committed: https://chromium.googlesource.com/chromium/src/+/5553b9f830b3f917d2500762a9455cb1f28dd0b1

[elawrence, 2017-05-11 21:50:10]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[elawrence, 2017-05-11 21:50:48]

elawrence@chromium.org changed reviewers:
+ pfeldman@chromium.org

[elawrence, 2017-05-11 21:50:49]

PTAL at this three character change? Thanks!

[commit-bot: I haz the power, 2017-05-11 21:51:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 22:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:39:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-05-13 01:01:32]

On 2017/05/11 21:50:49, elawrence wrote:
> PTAL at this three character change? Thanks!

We don't use title casing in DevTools.

[srahim, 2017-05-18 18:14:38]

On 2017/05/13 01:01:32, pfeldman wrote:
> On 2017/05/11 21:50:49, elawrence wrote:
> > PTAL at this three character change? Thanks!
> 
> We don't use title casing in DevTools.

pfeldman@, Dev Tools isn't perfectly consistent w/capitalization either way, but
there is a preponderance of title case. I think elawrence's change is fine; at
the very least, doesn't it make this title consistent with the others on the
security panel?

[pfeldman, 2017-05-18 18:43:46]

> pfeldman@, Dev Tools isn't perfectly consistent w/capitalization either way

That's what I'd like to fix. I assume there is a preference towards not
capitalizing in the UI (see chrome://settings).

> but there is a preponderance of title case.

Quite the opposite, it may be the case for Security panel, but that is an
oversight related to non-core team implementing the feature.

> I think elawrence's change is fine; at the very least, doesn't it make this
title consistent with the others on the
> security panel?

We can go the other way around and be consistent.

[elawrence, 2017-05-18 20:16:57]

On 2017/05/18 18:43:46, pfeldman wrote:
> > pfeldman@, Dev Tools isn't perfectly consistent w/capitalization either way
> 
> That's what I'd like to fix. I assume there is a preference towards not
> capitalizing in the UI (see chrome://settings).
> 
> > but there is a preponderance of title case.
> 
> Quite the opposite, it may be the case for Security panel, but that is an
> oversight related to non-core team implementing the feature.
> 
> > I think elawrence's change is fine; at the very least, doesn't it make this
> title consistent with the others on the
> > security panel?
> 
> We can go the other way around and be consistent.

As noted in the mail thread, there are approximately 50 instances of Title Case
in the Developer tools. For this CL, is your request that I:

1. Land the CL so all titles on the security panel are consistently Title Case.
2. Abandon the CL and leave this title in neither sentence nor title case.
3. Update the CL to sentence case "Non-secure forms", abandoning title case and
leaving it inconsistent with the other titles.
4. Update the CL to change all Security Panel explanation bullets to sentence
case, leaving it inconsistent with the use of title case elsewhere in the
security panel.
5. Abandon the CL and pursue a different CL to replace all use of title case in
the Developer Tools with sentence case
6. Something else?

thanks!

[pfeldman, 2017-05-18 20:35:47]

>> 4. Update the CL to change all Security Panel explanation bullets to sentence
case, leaving it inconsistent with the use of title case elsewhere in the
security panel.

I was going to ask for this before I read the sentence to the end and became
confused.

[elawrence, 2017-05-19 18:02:51]

Description was changed from

==========
Fix Non-Secure Form Title Casing in Security Panel of Developer Tools

Replace "Non-secure Form" with "Non-Secure Form"

BUG=721176
==========

to

==========
DevTools: Convert Security Panel to Sentence case

Replace use of Title Case in the Developer Tools' Security Panel to use sentence
case, matching Chrome text standards.

BUG=721176
==========

[elawrence, 2017-05-19 18:08:02]

Patchset #2 (id:20001) has been deleted

[elawrence, 2017-05-19 18:31:44]

elawrence@chromium.org changed reviewers:
+ estark@chromium.org

[elawrence, 2017-05-19 18:31:45]

estark@chromium.org: Please review changes in components/security_state*

[elawrence, 2017-05-19 18:31:58]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:33:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-05-19 18:35:07]

components/security_state lgtm

https://codereview.chromium.org/2881513003/diff/40001/components/security_sta...
File components/security_state/content/content_utils.cc (right):

https://codereview.chromium.org/2881513003/diff/40001/components/security_sta...
components/security_state/content/content_utils.cc:309: "Public-Key-Pinning
bypassed",
Huh. These should be in components/security_state_strings.grdp, not string
literals here. Totally optional -- if you want to fix that in this CL, that
would be great. Otherwise you or I can do it in a follow-up.

[elawrence, 2017-05-19 19:02:24]

https://codereview.chromium.org/2881513003/diff/40001/components/security_sta...
File components/security_state/content/content_utils.cc (right):

https://codereview.chromium.org/2881513003/diff/40001/components/security_sta...
components/security_state/content/content_utils.cc:309: "Public-Key-Pinning
bypassed",
On 2017/05/19 18:35:07, estark (temporarily slow) wrote:
> Huh. These should be in components/security_state_strings.grdp, not string
> literals here. Totally optional -- if you want to fix that in this CL, that
> would be great. Otherwise you or I can do it in a follow-up.

Done.

[pfeldman, 2017-05-19 19:50:38]

lgtm

https://codereview.chromium.org/2881513003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2881513003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:985:
sanDiv.textContent = Common.UIString('(n/a)');
I think it is common for N/A to be caps.

[elawrence, 2017-05-19 20:41:57]

On 2017/05/19 19:50:38, pfeldman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2881513003/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
> (right):
> 
>
https://codereview.chromium.org/2881513003/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:985:
> sanDiv.textContent = Common.UIString('(n/a)');
> I think it is common for N/A to be caps.

Thanks. I asked the writer about this one and apparently our official dictionary
uses "(n/a)" although "(N/A)" is permitted as a matter of taste. In this
particular case, the distinction is nearly moot, because CAs are required to use
SANs and Chrome58+ treat certificates lacking SANs as invalid.

[elawrence, 2017-05-19 20:42:08]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-19 20:42:08]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2881513003/#ps80001
(title: "Fix hardcoded UnitTest")

[commit-bot: I haz the power, 2017-05-19 20:43:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:50:14]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[elawrence, 2017-05-19 21:17:45]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-05-19 21:17:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2881513003/#ps100001
(title: "Fix unit test")

[commit-bot: I haz the power, 2017-05-19 21:18:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:26:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[elawrence, 2017-05-20 13:31:50]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-05-20 13:32:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 13:38:25]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495287110170660,
"parent_rev": "507bbc4d6eaf6ebd7b5ed1e63b611169e0d13308", "commit_rev":
"5553b9f830b3f917d2500762a9455cb1f28dd0b1"}

[commit-bot: I haz the power, 2017-05-20 13:38:37]

Description was changed from

==========
DevTools: Convert Security Panel to Sentence case

Replace use of Title Case in the Developer Tools' Security Panel to use sentence
case, matching Chrome text standards.

BUG=721176
==========

to

==========
DevTools: Convert Security Panel to Sentence case

Replace use of Title Case in the Developer Tools' Security Panel to use sentence
case, matching Chrome text standards.

BUG=721176

Review-Url: https://codereview.chromium.org/2881513003
Cr-Commit-Position: refs/heads/master@{#473435}
Committed:
https://chromium.googlesource.com/chromium/src/+/5553b9f830b3f917d2500762a945...
==========

[commit-bot: I haz the power, 2017-05-20 13:38:38]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5553b9f830b3f917d2500762a945...