Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2881463003: Reduce unnecessary download interruptions due to parallel requests (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Reduce unnecessary download interruptions due to parallel requests If a parallel request fails to when response starts, it will interrupt the download. However, the failure may be recoverable by the main requst. And this issue may cause a download to never finish even if user resumes it. This change fixes the issue by allowing the failure to passthrough to DownloadFileImpl. So that DownloadFileImpl can check whether the failure is recoverable. A side effect of this change is more we will create received_slice vector even if all parallel requests fails. This can be addressed in later changes. BUG=720057 TBR=dtrainor@chromium.org Review-Url: https://codereview.chromium.org/2872943003 Cr-Original-Commit-Position: refs/heads/master@{#470994} Review-Url: https://codereview.chromium.org/2881463003 . Cr-Commit-Position: refs/branch-heads/3071@{#522} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1882066650be756a0dc62dfdabf54bf1f3f9241b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M content/browser/download/download_file_impl.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M content/browser/download/download_job.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/download/download_job.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/download/download_worker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/download/download_worker.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M content/browser/download/parallel_download_job.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/download/parallel_download_job.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 7 months ago (2017-05-12 00:13:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1882066650be756a0dc62dfdabf54bf1f3f9241b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698