DevTools: update buttons to new style

DevTools: update buttons to new style

Please see crbug for a screenshot.

BUG=690239
Review-Url: https://codereview.chromium.org/2881453003
Cr-Commit-Position: refs/heads/master@{#477194}
Committed: https://chromium.googlesource.com/chromium/src/+/067ae0c565d431228fbcada9823b47d371f54b7d

[luoe, 2017-05-12 01:19:35]

Patchset #1 (id:1) has been deleted

[luoe, 2017-05-12 01:19:41]

Patchset #1 (id:20001) has been deleted

[luoe, 2017-05-12 01:21:24]

Description was changed from

==========
harmony buttons

BUG=
==========

to

==========
DevTools: update buttons to new style

Please see crbug for a screenshot.

BUG=690239
==========

[luoe, 2017-05-12 03:06:48]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org, pfeldman@chromium.org

[luoe, 2017-05-12 03:06:48]

Please take a look.

Known issues: ctrl-F in Sources still has old find/replace style buttons. 
Everything else should be updated.

https://codereview.chromium.org/2881453003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
(right):

https://codereview.chromium.org/2881453003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css:130:
.profile-launcher-view-content button {
I've moved the 'take snapshot' / 'start' button to be next to the 'load button'.

[luoe, 2017-05-12 23:33:04]

luoe@chromium.org changed reviewers:
+ einbinder@chromium.org

[dgozman, 2017-05-15 21:28:59]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-05-15 21:29:00]

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:76:
UI.createTextButton(Common.UIString('Perform an audit\u2026'),
this._showLauncherUI.bind(this), 'primary');
Let's either pass a boolean primary, or have two methods (e.g.
createPrimaryButton)

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js:494:
addButton.classList.add('primary');
Let's do this unconditionally?

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js:43:
actionContainer.appendChild(viewMoreButton);
nit: can inline this

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js:52:
this._contentElement.appendChild(this._controlButton);
Why different parent?

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
(left):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css:163:
.profile-launcher-view-content button.running {
What happened to running state?

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (left):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:111: var
prevButtonElement = this._buttonsContainer.createChild('button',
'search-action-button');
Let's remove these in a separate patch.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:500:
UI.SearchableView._lastUniqueId = 0;
Remove this one as well.

[luoe, 2017-05-18 21:29:26]

Please check this out.

Blue buttons should all use the same blue, (including blue setting gear toggle
button).

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:76:
UI.createTextButton(Common.UIString('Perform an audit\u2026'),
this._showLauncherUI.bind(this), 'primary');
On 2017/05/15 21:29:00, dgozman wrote:
> Let's either pass a boolean primary, or have two methods (e.g.
> createPrimaryButton)

Done as boolean primary.  I don't think we need to have title as a parameter,
it's only used in one location (FilmStripView) and none of the other UIUtils
builders have it.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js:494:
addButton.classList.add('primary');
On 2017/05/15 21:29:00, dgozman wrote:
> Let's do this unconditionally?

Done.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js:43:
actionContainer.appendChild(viewMoreButton);
On 2017/05/15 21:29:00, dgozman wrote:
> nit: can inline this

Done.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
(right):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js:52:
this._contentElement.appendChild(this._controlButton);
On 2017/05/15 21:29:00, dgozman wrote:
> Why different parent?

Before this CL, the action button might be on the same line as a target selector
dropdown
http://imgur.com/a/MHMjL

After this CL, the action button (start) will be on a new line, to the left of
the Load button.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
(left):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css:163:
.profile-launcher-view-content button.running {
On 2017/05/15 at 21:29:00, dgozman wrote:
> What happened to running state?

Hmm, since it's only used in Memory, I'll move it back here instead of
textButton.css.  When recording an allocation timeline, we should also remove
the primary blue background.

I think the inactive style is no longer needed.

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (left):

https://codereview.chromium.org/2881453003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:111: var
prevButtonElement = this._buttonsContainer.createChild('button',
'search-action-button');
On 2017/05/15 at 21:29:00, dgozman wrote:
> Let's remove these in a separate patch.

Done.

[luoe, 2017-05-23 23:21:05]

Patchset #5 (id:120001) has been deleted

[luoe, 2017-05-24 23:34:45]

luoe@chromium.org changed reviewers:
- dgozman@chromium.org, einbinder@chromium.org, lushnikov@chromium.org,
pfeldman@chromium.org

[luoe, 2017-05-26 23:38:40]

Patchset #6 (id:160001) has been deleted

[luoe, 2017-05-31 22:39:26]

Patchset #6 (id:180001) has been deleted

[luoe, 2017-06-01 01:38:49]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, einbinder@chromium.org, pfeldman@chromium.org

[luoe, 2017-06-01 01:38:50]

Now that the cleanup CL has been reviewed, this CL is ready for review as well.

Please take a look.

[pfeldman, 2017-06-01 21:11:36]

lgtm

https://codereview.chromium.org/2881453003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/ui/textButton.css (right):

https://codereview.chromium.org/2881453003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/ui/textButton.css:40:
:host(.primary), -theme-preserve {
consider using a more specific selector name (.primary-button)

[luoe, 2017-06-01 21:47:16]

Thanks for the reviews!

https://codereview.chromium.org/2881453003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/ui/textButton.css (right):

https://codereview.chromium.org/2881453003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/ui/textButton.css:40:
:host(.primary), -theme-preserve {
On 2017/06/01 21:11:36, pfeldman wrote:
> consider using a more specific selector name (.primary-button)

Done.

[luoe, 2017-06-05 22:59:33]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-06-05 22:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2881453003/#ps300001
(title: "a")

[commit-bot: I haz the power, 2017-06-05 23:00:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 00:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 00:57:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2017-06-06 01:05:49]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-06-06 01:05:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2881453003/#ps320001
(title: "fix test")

[commit-bot: I haz the power, 2017-06-06 01:06:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1496711149124090,
"parent_rev": "6fd962cb3e87ed2c1738f63b6a730f63badf7bf8", "commit_rev":
"067ae0c565d431228fbcada9823b47d371f54b7d"}

[commit-bot: I haz the power, 2017-06-06 04:28:27]

Description was changed from

==========
DevTools: update buttons to new style

Please see crbug for a screenshot.

BUG=690239
==========

to

==========
DevTools: update buttons to new style

Please see crbug for a screenshot.

BUG=690239

Review-Url: https://codereview.chromium.org/2881453003
Cr-Commit-Position: refs/heads/master@{#477194}
Committed:
https://chromium.googlesource.com/chromium/src/+/067ae0c565d431228fbcada9823b...
==========

[commit-bot: I haz the power, 2017-06-06 04:28:28]

Committed patchset #12 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/067ae0c565d431228fbcada9823b...