Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2881443003: Worklet: Move tests for Worklet in inspector/console/ to http/tests/inspector/console/ (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, darktears, blink-reviews, kozyatinskiy+blink_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move tests for Worklet in inspector/console/ to http/tests/inspector/console/ After ES6 modules loading for PaintWorklet (issue 627945) is introduced, layout tests for PaintWorklet are no longer able to run on non-http environment because ES6 modules does not support "file://" url (See https://crbug.com/594639#c86). This CL moves the tests in inspector/console/ to http/tests/inspector/console/ to enable them to run with module loading. BUG=719857 Review-Url: https://codereview.chromium.org/2881443003 Cr-Commit-Position: refs/heads/master@{#471076} Committed: https://chromium.googlesource.com/chromium/src/+/a8da913d44ef4a4846ac31d5bc66dc253d5f150e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-animation-worklet.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-animation-worklet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-paint-worklet.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-paint-worklet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/console/console-worklet-script.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-on-animation-worklet.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-on-animation-worklet-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-worklet-script.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nhiroki
Hi, can you review this? Thanks.
3 years, 7 months ago (2017-05-11 04:18:38 UTC) #4
dgozman
lgtm
3 years, 7 months ago (2017-05-11 20:50:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881443003/1
3 years, 7 months ago (2017-05-11 21:18:22 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 21:25:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8da913d44ef4a4846ac31d5bc66...

Powered by Google App Engine
This is Rietveld 408576698