Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2881443002: Add EME contentType checks for mp2t (Closed)

Created:
3 years, 7 months ago by yucliu1
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, eme-reviews_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EME contentType checks for mp2t We don't have 'mp2t/audio' for audio streams. For video streams, stream parser supports encrypted AVC stream. The patch adds the supporting for mp2t avc. BUG=708261 TEST=Test on chromecast and Android. Review-Url: https://codereview.chromium.org/2881443002 Cr-Commit-Position: refs/heads/master@{#473633} Committed: https://chromium.googlesource.com/chromium/src/+/a26af12f05559a607d50c22d94135b18902167eb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rename and VP9 #

Patch Set 4 : Restore PS2 #

Patch Set 5 : Name and comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M media/base/eme_constants.h View 1 2 3 4 3 chunks +13 lines, -0 lines 0 comments Download
M media/base/key_systems.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 39 (15 generated)
yucliu1
3 years, 7 months ago (2017-05-11 00:13:36 UTC) #3
chcunningham
LGTM, but I would wait for xhwang to also take a look
3 years, 7 months ago (2017-05-12 22:35:32 UTC) #4
xhwang
+ddorwin for discussion. WDYT? The pattern EME_CODEC_COMMON_* was first added for VP9 in MP4 support: ...
3 years, 7 months ago (2017-05-15 18:36:40 UTC) #6
xhwang
Another option is to list all mime/container types supported by the codec, e.g. instead of ...
3 years, 7 months ago (2017-05-15 18:45:36 UTC) #7
yucliu1
On 2017/05/15 18:36:40, xhwang wrote: > +ddorwin for discussion. WDYT? > > The pattern EME_CODEC_COMMON_* ...
3 years, 7 months ago (2017-05-15 18:47:01 UTC) #8
xhwang
On 2017/05/15 18:47:01, yucliu1 wrote: > On 2017/05/15 18:36:40, xhwang wrote: > > +ddorwin for ...
3 years, 7 months ago (2017-05-15 18:56:50 UTC) #9
yucliu1
On 2017/05/15 18:56:50, xhwang wrote: > On 2017/05/15 18:47:01, yucliu1 wrote: > > On 2017/05/15 ...
3 years, 7 months ago (2017-05-15 19:02:36 UTC) #10
chcunningham
> > > Now in the CL we are adding another mime type "video/mp2t", and ...
3 years, 7 months ago (2017-05-15 19:08:02 UTC) #11
chcunningham
> I agree. The key system doesn't need to care about the container also, since ...
3 years, 7 months ago (2017-05-15 19:14:29 UTC) #12
yucliu1
On 2017/05/15 19:14:29, chcunningham wrote: > > I agree. The key system doesn't need to ...
3 years, 7 months ago (2017-05-16 22:38:39 UTC) #13
xhwang
On 2017/05/16 22:38:39, yucliu1 wrote: > On 2017/05/15 19:14:29, chcunningham wrote: > > > I ...
3 years, 7 months ago (2017-05-16 22:45:18 UTC) #14
ddorwin
I think this enum was added for the prefixed EME implementation and before we had ...
3 years, 7 months ago (2017-05-17 16:50:17 UTC) #15
ddorwin
P.S. It would be better if KeySystems didn't have to deal with codec strings and ...
3 years, 7 months ago (2017-05-17 17:01:35 UTC) #16
yucliu1
On 2017/05/17 16:50:17, ddorwin wrote: > I think this enum was added for the prefixed ...
3 years, 7 months ago (2017-05-18 20:37:53 UTC) #17
yucliu1
1. Rename COMMON_VP9 to VP9, WEBM_VP9 to VP9_LEGACY, COMMON_AVC1 to AVC1 2. Add missing VP9 ...
3 years, 7 months ago (2017-05-18 21:45:42 UTC) #21
xhwang
yucliu: Thanks for the clean up! I just filed https://bugs.chromium.org/p/chromium/issues/detail?id=724362 to track the clean up ...
3 years, 7 months ago (2017-05-19 05:08:58 UTC) #22
yucliu1
On 2017/05/19 05:08:58, xhwang wrote: > yucliu: Thanks for the clean up! > > I ...
3 years, 7 months ago (2017-05-19 20:08:29 UTC) #24
xhwang
Thanks! LGTM
3 years, 7 months ago (2017-05-19 21:06:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881443002/80001
3 years, 7 months ago (2017-05-19 23:24:27 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/273365) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-19 23:33:09 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881443002/80001
3 years, 7 months ago (2017-05-19 23:56:32 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298855)
3 years, 7 months ago (2017-05-20 03:08:20 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881443002/80001
3 years, 7 months ago (2017-05-22 16:47:42 UTC) #36
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:35:43 UTC) #39
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a26af12f05559a607d50c22d9413...

Powered by Google App Engine
This is Rietveld 408576698