Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2881383003: Rename TaskRunner::RunsTasksOnCurrentThread() in //android_webview, //tools (Closed)

Created:
3 years, 7 months ago by Yeol Park
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TaskRunner::RunsTasksOnCurrentThread() in //android_webview, //tools renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner::RunsTasksInCurrentSequence() in //android_webview, //tools BUG=665062 Review-Url: https://codereview.chromium.org/2881383003 Cr-Commit-Position: refs/heads/master@{#472641} Committed: https://chromium.googlesource.com/chromium/src/+/3808747e5108af5ddb3825af7ae5a23b20fe1356

Patch Set 1 #

Patch Set 2 : add //tools/android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M android_webview/browser/cookie_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_cookie_store_wrapper.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M tools/android/forwarder2/device_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/device_listener.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/forwarders_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/host_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_controllers_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/self_deleter_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Yeol Park
PTAL :) boliu@, michaelbai@ for android_webview
3 years, 7 months ago (2017-05-17 06:38:26 UTC) #3
Yeol Park
PTAL :) boliu@, michaelbai@ for //android_webview digit@, jbudorick@ for //tools/android
3 years, 7 months ago (2017-05-17 08:07:27 UTC) #4
Yeol Park
PTAL :) boliu@, michaelbai@ for //android_webview digit@, jbudorick@ for //tools/android
3 years, 7 months ago (2017-05-17 08:08:38 UTC) #7
jbudorick
On 2017/05/17 08:08:38, Yeol Park wrote: > PTAL :) > > boliu@, michaelbai@ for //android_webview ...
3 years, 7 months ago (2017-05-17 15:51:23 UTC) #8
boliu
lgtm
3 years, 7 months ago (2017-05-17 16:01:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881383003/20001
3 years, 7 months ago (2017-05-18 02:13:43 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:41:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3808747e5108af5ddb3825af7ae5...

Powered by Google App Engine
This is Rietveld 408576698