Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2881383002: Photo Picker Dialog: Fix Gallery button vector drawable tinting. (Closed)

Created:
3 years, 7 months ago by Finnur
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker Dialog: Fix Gallery button vector drawable tinting. BUG=656015 Review-Url: https://codereview.chromium.org/2881383002 Cr-Commit-Position: refs/heads/master@{#472120} Committed: https://chromium.googlesource.com/chromium/src/+/18ec131dc99d91763d525370ce6d40f92805f207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Finnur
Without this, the tinting of the vector drawable wouldn't always work (it would remain un-tinted ...
3 years, 7 months ago (2017-05-16 14:16:38 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-16 15:03:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881383002/1
3 years, 7 months ago (2017-05-16 15:55:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 16:04:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18ec131dc99d91763d525370ce6d...

Powered by Google App Engine
This is Rietveld 408576698