Support Document constructor.

Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ12LwjKAAAJ

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043
Review-Url: https://codereview.chromium.org/2881323002
Cr-Commit-Position: refs/heads/master@{#473931}
Committed: https://chromium.googlesource.com/chromium/src/+/ef4b834e59e5d1bcf0e945445ada37f2e5e90b84

[tkent, 2017-05-16 02:46:28]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 02:46:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-16 05:27:46]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-05-16 05:28:09]

Patchset #1 (id:1) has been deleted

[tkent, 2017-05-16 05:28:14]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-05-16 05:28:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-16 06:14:35]

Description was changed from

==========
Support Document constructor.


BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...


BUG=238234, 643043
==========

[tkent, 2017-05-16 06:40:51]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...


BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixed 161 failures in external/wpt/.

This CL add 'origin' test to dom/nodes/Document-constructor.html.

BUG=238234, 643043
==========

[tkent, 2017-05-16 06:41:13]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixed 161 failures in external/wpt/.

This CL add 'origin' test to dom/nodes/Document-constructor.html.

BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixed 161 failures in external/wpt/.

This CL adds 'origin' check to dom/nodes/Document-constructor.html of WPT.

BUG=238234, 643043
==========

[tkent, 2017-05-16 06:55:51]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixed 161 failures in external/wpt/.

This CL adds 'origin' check to dom/nodes/Document-constructor.html of WPT.

BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 161 failures in external/wpt/.

This CL adds 'origin' check to dom/nodes/Document-constructor.html of WPT.

BUG=238234, 643043
==========

[commit-bot: I haz the power, 2017-05-16 07:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 07:14:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-05-16 07:32:55]

tkent@chromium.org changed reviewers:
+ dominicc@chromium.org

[tkent, 2017-05-16 07:32:55]

dominicc@, would you review this please?

[dominicc (has gone to gerrit), 2017-05-17 05:50:33]

Sorry for the slow reply.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-constructor-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-constructor-expected.txt:6:
FAIL new Document(): URL parsing assert_equals: expected
"http://example.org/?%C3%A4" but got "http://example.org/?ä"
crbug for this?

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt:4:
FAIL new document assert_equals: new document has empty domain expected "" but
got "web-platform.test"
It looks like this needs work.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:494: Document*
Document::Create(const Document& document) {
Could we add a unit test for this? In particular, can you break it when you call
it with different kinds of documents? Where does the application/xml MIME type
come from, for example?

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:264: static Document* Create(const
Document&);
Maybe give this a more detailed name, or at least a comment? What is the other
document?

[tkent, 2017-05-17 08:42:18]

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-constructor-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-constructor-expected.txt:6:
FAIL new Document(): URL parsing assert_equals: expected
"http://example.org/?%C3%A4" but got "http://example.org/?ä"
On 2017/05/17 at 05:50:33, dominicc wrote:
> crbug for this?

I don't know.  This failure isn't so related to Document constructor support.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt:4:
FAIL new document assert_equals: new document has empty domain expected "" but
got "web-platform.test"
On 2017/05/17 at 05:50:33, dominicc wrote:
> It looks like this needs work.

yeah, I found a bug.  Will fix.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:494: Document*
Document::Create(const Document& document) {
On 2017/05/17 at 05:50:33, dominicc wrote:
> Could we add a unit test for this? In particular, can you break it when you
call it with different kinds of documents? Where does the application/xml MIME
type come from, for example?

Do you mean C++ unit test?
Basically the behavior is web-exposed, and we should have wpt tests instead of
C++ unit test.  Maybe adding wpt/dom/nodes/Document-constructor-svg.svg,
Document-constructor-xml.xml is appropriate.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:264: static Document* Create(const
Document&);
On 2017/05/17 at 05:50:33, dominicc wrote:
> Maybe give this a more detailed name, or at least a comment? What is the other
document?

It seems binding generator doesn't have a capability to change constructor
function names.  I'll add a comment.

[tkent, 2017-05-17 09:05:59]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 09:06:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-17 09:08:29]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 161 failures in external/wpt/.

This CL adds 'origin' check to dom/nodes/Document-constructor.html of WPT.

BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 161 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043
==========

[commit-bot: I haz the power, 2017-05-17 10:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 10:45:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-05-19 02:17:46]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-05-19 02:17:59]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-19 02:18:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:51:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tkent, 2017-05-19 04:03:59]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-05-19 04:04:10]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 161 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043
==========

[commit-bot: I haz the power, 2017-05-19 04:04:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-19 04:12:40]

Patchset #2 (id:80001) has been deleted

[tkent, 2017-05-19 06:05:07]

I uploaded new patch.

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt:4:
FAIL new document assert_equals: new document has empty domain expected "" but
got "web-platform.test"
On 2017/05/17 at 08:42:18, tkent wrote:
> On 2017/05/17 at 05:50:33, dominicc wrote:
> > It looks like this needs work.
> 
> yeah, I found a bug.  Will fix.

Looks this is a specification error. All major browsers agree that |domain| of
document.implementation.createDocument() and |new Document()| inherits from the
window.document.domain. I'll file a specification bug.

[tkent, 2017-05-19 06:28:46]

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt
(right):

https://codereview.chromium.org/2881323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt:4:
FAIL new document assert_equals: new document has empty domain expected "" but
got "web-platform.test"
On 2017/05/19 at 06:05:07, tkent wrote:
> On 2017/05/17 at 08:42:18, tkent wrote:
> > On 2017/05/17 at 05:50:33, dominicc wrote:
> > > It looks like this needs work.
> > 
> > yeah, I found a bug.  Will fix.
> 
> Looks this is a specification error. All major browsers agree that |domain| of
document.implementation.createDocument() and |new Document()| inherits from the
window.document.domain. I'll file a specification bug.

Filed: https://github.com/whatwg/html/issues/2697

[commit-bot: I haz the power, 2017-05-19 07:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:05:04]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2017-05-23 13:17:18]

Sorry again for the slow reply. Very nice comment. LGTM.

[dominicc (has gone to gerrit), 2017-05-23 13:17:24]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2017-05-23 13:17:24]

lgtm

[commit-bot: I haz the power, 2017-05-23 13:17:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:23:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495545444204210,
"parent_rev": "b8b1cbadd7941505caf3cdaebfa30f019854f815", "commit_rev":
"ef4b834e59e5d1bcf0e945445ada37f2e5e90b84"}

[commit-bot: I haz the power, 2017-05-23 16:24:08]

Description was changed from

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043
==========

to

==========
Support Document constructor.

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ...

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043

Review-Url: https://codereview.chromium.org/2881323002
Cr-Commit-Position: refs/heads/master@{#473931}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef4b834e59e5d1bcf0e945445ada...
==========

[commit-bot: I haz the power, 2017-05-23 16:24:09]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/ef4b834e59e5d1bcf0e945445ada...