add interface to start first run when voice interaction oobe is completed

add interface to start first run when voice interaction oobe is completed

BUG=b:38123645
TEST=First run tutorial is started after voice interaction
  OOBE completed broadcast.

Review-Url: https://codereview.chromium.org/2881283002
Cr-Commit-Position: refs/heads/master@{#472188}
Committed: https://chromium.googlesource.com/chromium/src/+/b1ec21c001f5ce18fdf182d07c82ffface55afe9

[Muyuan, 2017-05-15 22:11:51]

muyuanli@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org

[Muyuan, 2017-05-15 22:11:52]

lhchavez: could you please look at everything plz :p

dcheng: mojo calls

[Luis Héctor Chávez, 2017-05-15 22:17:06]

https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:111: [MinVersion=16]
OnVoiceInteractionOobeSetupCompleted@6();
Can this be in another .mojom? I'd like to avoid adding (more) random stuff
here.

[Muyuan, 2017-05-15 22:24:21]

On 2017/05/15 22:17:06, Luis Héctor Chávez wrote:
>
https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
> File components/arc/common/intent_helper.mojom (right):
> 
>
https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
> components/arc/common/intent_helper.mojom:111: [MinVersion=16]
> OnVoiceInteractionOobeSetupCompleted@6();
> Can this be in another .mojom? I'd like to avoid adding (more) random stuff
> here.

OK.. I though it was intended to throw in random stuff there :(

I could move this call to arc_voice_interaction_framework_service or
arc_voice_interaction_arc_home_service, wdyt?

[Luis Héctor Chávez, 2017-05-15 22:25:42]

On 2017/05/15 22:24:21, Muyuan wrote:
> On 2017/05/15 22:17:06, Luis Héctor Chávez wrote:
> >
>
https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
> > File components/arc/common/intent_helper.mojom (right):
> > 
> >
>
https://codereview.chromium.org/2881283002/diff/1/components/arc/common/inten...
> > components/arc/common/intent_helper.mojom:111: [MinVersion=16]
> > OnVoiceInteractionOobeSetupCompleted@6();
> > Can this be in another .mojom? I'd like to avoid adding (more) random stuff
> > here.
> 
> OK.. I though it was intended to throw in random stuff there :(
> 
> I could move this call to arc_voice_interaction_framework_service or
> arc_voice_interaction_arc_home_service, wdyt?

either one of those are good candidates. use the one that makes more sense for
the Android-side implementation.

[dcheng, 2017-05-16 10:09:10]

mojom lgtm

[Luis Héctor Chávez, 2017-05-16 15:52:49]

lgtm

[Luis Héctor Chávez, 2017-05-16 15:53:33]

ah missed a nit.

https://codereview.chromium.org/2881283002/diff/20001/components/arc/common/v...
File components/arc/common/voice_interaction_arc_home.mojom (right):

https://codereview.chromium.org/2881283002/diff/20001/components/arc/common/v...
components/arc/common/voice_interaction_arc_home.mojom:60: // Notified
VoiceInteractionArcHomeHost that voice interaction OOBE setup
nit: s/Notified/Notifies/

[Muyuan, 2017-05-16 18:12:27]

https://codereview.chromium.org/2881283002/diff/20001/components/arc/common/v...
File components/arc/common/voice_interaction_arc_home.mojom (right):

https://codereview.chromium.org/2881283002/diff/20001/components/arc/common/v...
components/arc/common/voice_interaction_arc_home.mojom:60: // Notified
VoiceInteractionArcHomeHost that voice interaction OOBE setup
On 2017/05/16 15:53:32, Luis Héctor Chávez wrote:
> nit: s/Notified/Notifies/

Done.

[Muyuan, 2017-05-16 18:12:33]

The CQ bit was checked by muyuanli@chromium.org

[Muyuan, 2017-05-16 18:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2881283002/#ps40001
(title: "address review comment")

[commit-bot: I haz the power, 2017-05-16 18:13:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:37:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494958353068320,
"parent_rev": "f53247a6fbf1240613a9a79be36b6a3650fd19ec", "commit_rev":
"b1ec21c001f5ce18fdf182d07c82ffface55afe9"}

[commit-bot: I haz the power, 2017-05-16 19:37:59]

Description was changed from

==========
add interface to start first run when voice interaction oobe is completed

BUG=b:38123645
TEST=First run tutorial is started after voice interaction
  OOBE completed broadcast.
==========

to

==========
add interface to start first run when voice interaction oobe is completed

BUG=b:38123645
TEST=First run tutorial is started after voice interaction
  OOBE completed broadcast.

Review-Url: https://codereview.chromium.org/2881283002
Cr-Commit-Position: refs/heads/master@{#472188}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1ec21c001f5ce18fdf182d07c82...
==========

[commit-bot: I haz the power, 2017-05-16 19:38:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b1ec21c001f5ce18fdf182d07c82...

[xc, 2017-05-18 18:36:20]

xiaohuic@chromium.org changed reviewers:
+ xiaohuic@chromium.org

[xc, 2017-05-18 18:36:21]

https://codereview.chromium.org/2881283002/diff/40001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
(right):

https://codereview.chromium.org/2881283002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc:117:
chromeos::FirstRunController::Start();
Need to use chromeos::first_run::MaybeLaunchDialogAfterSessionStart avoid firing
many times if the user skipped during initial OOBE but comes back later.