Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2881243002:
Refresh the lock screen PIN keyboard (Closed)
|
Created:
3 years, 7 months ago by Wenzhao (Colin) Zang Modified:
3 years, 7 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rkc Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefresh the lock screen PIN keyboard
The goal is to make the PIN keyboard match the design spec.
It does not change the underlying implementation or behavior of the PIN
keyboard, except:
1) Hide the ‘first-row’ in PIN keyboard in md_pin_keyboard.html. It
will be re-evaluated when dealing with the edge cases.
2) ‘Signed-in-indicator’ in md_user_pod_template.html is removed and
will be replaced by a badge in subsequent CLs.
BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2881243002
Cr-Commit-Position: refs/heads/master@{#473110}
Committed: https://chromium.googlesource.com/chromium/src/+/653344bc2486f15443939ac75a99c07cc79496aa
Patch Set 1 #
Total comments: 2
Messages
Total messages: 48 (25 generated)
Description was changed from ========== Login screen redesign (CL 2) BUG=718174 ========== to ========== Login screen redesign (CL 2) BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Login screen redesign (CL 2) BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Login screen redesign (CL 2) Make the lock screen PIN keyboard look the same with the mock here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7M... It does not change the underlying implementation of PIN keyboard at all. BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
wzang@chromium.org changed reviewers: + alemate@google.com, jdufault@chromium.org
wzang@chromium.org changed reviewers: + alemate@chromium.org - alemate@google.com
wzang@chromium.org changed reviewers: + xiyuan@chromium.org
xiyuan@, please take look at this file: chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html The whole page is hidden behind a flag so it doesn't affect the current PIN keyboard. Thank you. alemate@, jdufault@, please take a look at the other files. Thanks you.
https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... File ui/login/account_picker/md_user_pod_template.html (left): https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... ui/login/account_picker/md_user_pod_template.html:32: <div class="signed-in-indicator" i18n-content="signedIn"></div> What was this used for?
https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... File ui/login/account_picker/md_user_pod_template.html (left): https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... ui/login/account_picker/md_user_pod_template.html:32: <div class="signed-in-indicator" i18n-content="signedIn"></div> On 2017/05/15 22:57:46, jdufault wrote: > What was this used for? This is a line of texts appearing on top of the avatar at the lock screen. It will be replaced with a badge in the next CL according to page 3 of the new spec.
On 2017/05/15 23:01:18, Wenzhao (Colin) Zang wrote: > https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... > File ui/login/account_picker/md_user_pod_template.html (left): > > https://codereview.chromium.org/2881243002/diff/1/ui/login/account_picker/md_... > ui/login/account_picker/md_user_pod_template.html:32: <div > class="signed-in-indicator" i18n-content="signedIn"></div> > On 2017/05/15 22:57:46, jdufault wrote: > > What was this used for? > > This is a line of texts appearing on top of the avatar at the lock screen. It > will be replaced with a badge in the next CL according to page 3 of the new > spec. okay. lgtm
lgtm
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495172270973670, "parent_rev":
"a8add0308ba6067eb3de5a8fe82f9c2f2460ad91", "commit_rev":
"653344bc2486f15443939ac75a99c07cc79496aa"}
Message was sent while issue was closed.
Description was changed from ========== Login screen redesign (CL 2) Make the lock screen PIN keyboard look the same with the mock here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7M... It does not change the underlying implementation of PIN keyboard at all. BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Login screen redesign (CL 2) Make the lock screen PIN keyboard look the same with the mock here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7M... It does not change the underlying implementation of PIN keyboard at all. BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881243002 Cr-Commit-Position: refs/heads/master@{#473110} Committed: https://chromium.googlesource.com/chromium/src/+/653344bc2486f15443939ac75a99... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/653344bc2486f15443939ac75a99...
Message was sent while issue was closed.
Description was changed from ========== Login screen redesign (CL 2) Make the lock screen PIN keyboard look the same with the mock here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7M... It does not change the underlying implementation of PIN keyboard at all. BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881243002 Cr-Commit-Position: refs/heads/master@{#473110} Committed: https://chromium.googlesource.com/chromium/src/+/653344bc2486f15443939ac75a99... ========== to ========== Refresh the lock screen PIN keyboard The goal is to make the PIN keyboard match the design spec. It does not change the underlying implementation or behavior of the PIN keyboard, except: 1) Hide the ‘first-row’ in PIN keyboard in md_pin_keyboard.html. It will be re-evaluated when dealing with the edge cases. 2) ‘Signed-in-indicator’ in md_user_pod_template.html is removed and will be replaced by a badge in subsequent CLs. BUG=718174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881243002 Cr-Commit-Position: refs/heads/master@{#473110} Committed: https://chromium.googlesource.com/chromium/src/+/653344bc2486f15443939ac75a99... ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
