Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2881213002: cc: Remove deprecated DisplayItemList::Raster overload. (Closed)

Created:
6 months ago by vmpstr
Modified:
6 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove deprecated DisplayItemList::Raster overload. This patch removes a deprecated overload of the Raster function since all callers pass scale 1.f, and a clip that is equivalent to the canvas clip. It also adds a default nullptr parameter to the abort callback. R=enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2881213002 Cr-Commit-Position: refs/heads/master@{#472118} Committed: https://chromium.googlesource.com/chromium/src/+/0fe340de16a0e01e09184ae98366c5b1f3b36b5d

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M cc/layers/recording_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/display_item_list.h View 1 chunk +1 line, -6 lines 0 comments Download
M cc/paint/display_item_list.cc View 2 chunks +1 line, -19 lines 0 comments Download
M cc/paint/display_item_list_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M cc/paint/paint_op_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/skia_paint_canvas.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_source.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_source.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/test/skia_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
vmpstr
Please take a look.
6 months ago (2017-05-15 18:28:54 UTC) #2
enne (OOO)
lgtm
6 months ago (2017-05-15 18:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881213002/20001
6 months ago (2017-05-15 19:36:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/411536)
6 months ago (2017-05-15 21:07:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881213002/20001
6 months ago (2017-05-15 21:10:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/427180)
6 months ago (2017-05-16 00:25:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881213002/20001
6 months ago (2017-05-16 15:05:09 UTC) #13
commit-bot: I haz the power
6 months ago (2017-05-16 16:01:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0fe340de16a0e01e09184ae98366...

Powered by Google App Engine
This is Rietveld efc10ee0f