ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm - Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm ('k') | ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

diff --git a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

index 4333cdbddea9d3a64f759c58b4fd810ce0ecb5fe..9e2768c3ef089715c1e536311f95b1d4ca6d3e43 100644

--- a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

+++ b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

@@ -7,7 +7,7 @@

#import <QuartzCore/QuartzCore.h>

#include "base/logging.h"

-#include "base/mac/objc_release_properties.h"

+#include "base/mac/objc_property_releaser.h"

#include "base/mac/scoped_nsobject.h"

#include "ios/chrome/browser/ui/rtl_geometry.h"

#include "ios/chrome/browser/ui/uikit_ui_util.h"

@@ -134,6 +134,7 @@

// The array is built the first time the method -layersToCenterVertically is

// called.

base::scoped_nsobject<NSArray> _layersToCenterVertically;

+ base::mac::ObjCPropertyReleaser _propertyReleaser_OverscrollActionsView;

}

// Redefined to readwrite.

@@ -241,6 +242,8 @@

- (instancetype)initWithFrame:(CGRect)frame {

self = [super initWithFrame:frame];

if (self) {

+ _propertyReleaser_OverscrollActionsView.Init(self,

+ [OverscrollActionsView class]);

_deformationBehaviorEnabled = YES;

self.autoresizingMask =

UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;

@@ -302,7 +305,6 @@

- (void)dealloc {

[self.snapshotView removeFromSuperview];

- base::mac::ReleaseProperties(self);

[super dealloc];

}