Remove PassRefPtr on setters in ComputedStyle.

Remove PassRefPtr on setters in ComputedStyle.

As we are going to remove PassRefPtr, this patch replaces uses of
PassRefPtr with RefPtr in ComputedStyle setters.

BUG=494719
Review-Url: https://codereview.chromium.org/2881143004
Cr-Commit-Position: refs/heads/master@{#472778}
Committed: https://chromium.googlesource.com/chromium/src/+/f48988f3854ac9d3e6beb282d349be7436b07cf5

[shend, 2017-05-16 04:26:05]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[shend, 2017-05-16 04:26:19]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-05-16 04:26:19]

Hi Bugs, PTAL :)

[commit-bot: I haz the power, 2017-05-16 04:26:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 06:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 06:10:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-05-16 23:15:19]

lgtm

Note that the call sites that call these methods with .Release() will also need
to be changed to call std::move instead. As is, this patch would cause those
instances to convert the RefPtr to a PassRefPtr, which is then implicitly
converted back into a RefPtr. It will work as is for now and it won't introduce
ref churn, but it is strange code. Personally I would make the changes from
.Release to std::move first.

[shend, 2017-05-18 05:10:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[shend, 2017-05-18 05:11:11]

shend@chromium.org changed reviewers:
+ yutak@chromium.org

[shend, 2017-05-18 05:11:11]

Done. Hi yutak, PTAL?

[commit-bot: I haz the power, 2017-05-18 05:11:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 05:16:28]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yuta Kitamura, 2017-05-18 05:49:53]

It seems that you have a patch conflict. Can you rebase your
patch and upload it again?

[shend, 2017-05-18 05:55:52]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 05:56:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-18 06:02:11]

On 2017/05/18 at 05:49:53, yutak wrote:
> It seems that you have a patch conflict. Can you rebase your
> patch and upload it again?

Done, sorry about that.

[Yuta Kitamura, 2017-05-18 06:06:23]

On 2017/05/18 06:02:11, shend wrote:
> On 2017/05/18 at 05:49:53, yutak wrote:
> > It seems that you have a patch conflict. Can you rebase your
> > patch and upload it again?
> 
> Done, sorry about that.

Nope, conflicts do happen and that's fine. I asked just because
I thought that'd be a good exercise for you :)

And this patch LGTM.

[commit-bot: I haz the power, 2017-05-18 10:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 10:07:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-05-18 10:32:54]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-18 10:32:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2881143004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-18 10:33:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 12:22:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495103574721700,
"parent_rev": "9ad27e95181462f0187240acd01a2737139aa94c", "commit_rev":
"f48988f3854ac9d3e6beb282d349be7436b07cf5"}

[commit-bot: I haz the power, 2017-05-18 12:22:23]

Description was changed from

==========
Remove PassRefPtr on setters in ComputedStyle.

As we are going to remove PassRefPtr, this patch replaces uses of
PassRefPtr with RefPtr in ComputedStyle setters.

BUG=494719
==========

to

==========
Remove PassRefPtr on setters in ComputedStyle.

As we are going to remove PassRefPtr, this patch replaces uses of
PassRefPtr with RefPtr in ComputedStyle setters.

BUG=494719

Review-Url: https://codereview.chromium.org/2881143004
Cr-Commit-Position: refs/heads/master@{#472778}
Committed:
https://chromium.googlesource.com/chromium/src/+/f48988f3854ac9d3e6beb282d349...
==========

[commit-bot: I haz the power, 2017-05-18 12:22:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f48988f3854ac9d3e6beb282d349...