Issue 288113009: Turn ASSERT_UNUSED into plain ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 288113009: Turn ASSERT_UNUSED into plain ASSERT (Closed)

Created:
6 years, 7 months ago by davve

Modified:
6 years, 7 months ago

Reviewers:
pdr., rune

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Turn ASSERT_UNUSED into plain ASSERT ASSERT_UNUSED used to be necessary, before the code paths for USE(CG) were removed in https://codereview.chromium.org/13616008. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174562

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/rendering/svg/RenderSVGResourceContainer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

davve

Part of some smallish things I stumbled into scanning through code to understand text rendering ...

6 years, 7 months ago (2014-05-22 06:52:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/288113009/1

6 years, 7 months ago (2014-05-22 08:11:08 UTC) #4

Message was sent while issue was closed.

Change committed as 174562

Expand Messages | Collapse Messages