Issue 13616008: Remove CG codepaths from SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13616008: Remove CG codepaths from SVG (Closed)

Created:
7 years, 8 months ago by pdr.

Modified:
7 years, 8 months ago

Reviewers:
Nico, eseidel1, eseidel

CC:
blink-reviews, pdr, Stephen Chennney, f(malita), jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove CG codepaths from SVG This change removes all "USE(CG)" references from the SVG codebase. The only live code change is RenderSVGResourceGradient::postApplyResource where previously we did not fill or stroke in the ApplyToTextMode case due to taking the CG-specific codepath. This now matches other RenderSVGResource*::postApplyResource functions. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147759

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -151 lines)			Patch
M	Source/WebCore/rendering/svg/RenderSVGRect.cpp	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGResourceGradient.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp	View	5 chunks	+14 lines, -107 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp	View	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pdr.

7 years, 8 months ago (2013-04-08 00:38:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r147759 (presubmit successful).

Expand Messages | Collapse Messages