Treat .scf files as dangerous.

Treat .scf files as dangerous.

hey'll show a warning on every download. These files are very rarely
downloaded, so it won't increase warning fatigue.

BUG=722524
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2881093003
Cr-Commit-Position: refs/heads/master@{#471941}
Committed: https://chromium.googlesource.com/chromium/src/+/25ac3c481a621cec69d1dec92abb7efee9a33d27

[Nathan Parker, 2017-05-15 21:12:39]

Description was changed from

==========
Treat .scf files as dangerous.

hey'll show a warning on every download. These files are very rarely
downloaded, so it won't increase warning fatigue.

BUG=722524
==========

to

==========
Treat .scf files as dangerous.

hey'll show a warning on every download. These files are very rarely
downloaded, so it won't increase warning fatigue.

BUG=722524
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Nathan Parker, 2017-05-15 21:12:43]

The CQ bit was checked by nparker@chromium.org to run a CQ dry run

[Nathan Parker, 2017-05-15 21:13:13]

nparker@chromium.org changed reviewers:
+ vakh@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:13:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2017-05-15 21:15:06]

lgtm

https://codereview.chromium.org/2881093003/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right):

https://codereview.chromium.org/2881093003/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/download_file_types.asciipb:2061: # Can
trigger network requests just by being displayed in explorer.
Windows Explorer is more accurate.

[Nathan Parker, 2017-05-15 21:18:17]

Fix comment, per vakh

[Nathan Parker, 2017-05-15 21:18:37]

Thanks.

https://codereview.chromium.org/2881093003/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right):

https://codereview.chromium.org/2881093003/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/download_file_types.asciipb:2061: # Can
trigger network requests just by being displayed in explorer.
On 2017/05/15 21:15:06, vakh (Varun Khaneja) wrote:
> Windows Explorer is more accurate.

Done.

[Nathan Parker, 2017-05-15 21:18:57]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2017-05-15 21:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from vakh@chromium.org
Link to the patchset: https://codereview.chromium.org/2881093003/#ps20001
(title: "Fix comment, per vakh")

[commit-bot: I haz the power, 2017-05-15 21:20:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:05:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494883137676980,
"parent_rev": "f4c4a4de426ccab70896c80c48e58b770420c008", "commit_rev":
"25ac3c481a621cec69d1dec92abb7efee9a33d27"}

[commit-bot: I haz the power, 2017-05-15 23:05:50]

Description was changed from

==========
Treat .scf files as dangerous.

hey'll show a warning on every download. These files are very rarely
downloaded, so it won't increase warning fatigue.

BUG=722524
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Treat .scf files as dangerous.

hey'll show a warning on every download. These files are very rarely
downloaded, so it won't increase warning fatigue.

BUG=722524
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2881093003
Cr-Commit-Position: refs/heads/master@{#471941}
Committed:
https://chromium.googlesource.com/chromium/src/+/25ac3c481a621cec69d1dec92abb...
==========

[commit-bot: I haz the power, 2017-05-15 23:05:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25ac3c481a621cec69d1dec92abb...