Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2881073002: Check for infrastructure failure before reporting timeouts and crashes. (Closed)

Created:
3 years, 7 months ago by Bill Hesse
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for infrastructure failure before reporting timeouts and crashes. BUG=http://dartbug.com/28955 Committed: https://github.com/dart-lang/sdk/commit/6f3d45f5a31064b5750ee721f3b337f34a11cbbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Bill Hesse
The IE11 timeouts were reported as timeouts before being handled as infrastructure failures.
3 years, 7 months ago (2017-05-15 14:23:52 UTC) #2
Bill Hesse
3 years, 7 months ago (2017-05-15 14:40:31 UTC) #3
Bill Hesse
TBR=sigmund@google.com
3 years, 7 months ago (2017-05-15 16:22:29 UTC) #4
Bill Hesse
Committed patchset #1 (id:1) manually as 6f3d45f5a31064b5750ee721f3b337f34a11cbbd (presubmit successful).
3 years, 7 months ago (2017-05-15 16:27:52 UTC) #8
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-17 16:25:38 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698