Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2881073002: Check for infrastructure failure before reporting timeouts and crashes. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index bedc8ef04042e2e2eb6ca0060da9c14fb232bd0b..ec0e91882158472c086e0fb22761b7a27ccf753f 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1087,14 +1087,14 @@ class BrowserCommandOutputImpl extends CommandOutputImpl {
compilationSkipped, 0);
Expectation result(TestCase testCase) {
+ if (_infraFailure) {
+ return Expectation.IGNORE;
+ }
// Handle crashes and timeouts first
if (hasCrashed) return Expectation.CRASH;
if (hasTimedOut) return Expectation.TIMEOUT;
if (hasNonUtf8) return Expectation.NON_UTF8_ERROR;
- if (_infraFailure) {
- return Expectation.IGNORE;
- }
var outcome = _getOutcome();
if (testCase.hasRuntimeError) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698