Take a screenshot whenever login fails.

Take a screenshot whenever login fails.

Some cleanup.

BUG=373862
TEST=manual
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271083

[achuithb, 2014-05-15 22:36:42]

Please review, Tim.

[Tim Song, 2014-05-15 23:09:46]

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:147:
self._WaitForBrowserToComeUp(wait_for_extensions=False)
Add a comment here that this first _WaitForBrowserToComeUp is actually waiting
for the login screen/oobe.

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:237: if
self._is_guest:
Why is guest mode different?

[achuithb, 2014-05-15 23:21:57]

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:147:
self._WaitForBrowserToComeUp(wait_for_extensions=False)
On 2014/05/15 23:09:46, Tim Song wrote:
> Add a comment here that this first _WaitForBrowserToComeUp is actually waiting
> for the login screen/oobe.

Done.

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:237: if
self._is_guest:
On 2014/05/15 23:09:46, Tim Song wrote:
> Why is guest mode different?

That's a good question. I believe I had a previous change that eliminated this
difference that started flaking, and I had to revert.

If you don't mind, I'll remove these 2 lines 237-238 in a follow-up CL that can
be easily reverted. Wdyt?

[achuithb, 2014-05-15 23:22:04]

PTAL

[Tim Song, 2014-05-15 23:42:18]

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:237: if
self._is_guest:
On 2014/05/15 23:21:57, achuithb wrote:
> On 2014/05/15 23:09:46, Tim Song wrote:
> > Why is guest mode different?
> 
> That's a good question. I believe I had a previous change that eliminated this
> difference that started flaking, and I had to revert.
> 
> If you don't mind, I'll remove these 2 lines 237-238 in a follow-up CL that
can
> be easily reverted. Wdyt?

My concern is that these checks change the semantics of the start up state,
relaxing the conditions for guest mode. If we can safely relax the conditions
for guest sessions, why can't we also do the same for regular user sessions?

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:252:
while not self._is_guest:
ditto.

[achuithb, 2014-05-16 18:38:54]

PTAL Tim.

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:237: if
self._is_guest:
On 2014/05/15 23:42:18, Tim Song wrote:
> On 2014/05/15 23:21:57, achuithb wrote:
> > On 2014/05/15 23:09:46, Tim Song wrote:
> > > Why is guest mode different?
> > 
> > That's a good question. I believe I had a previous change that eliminated
this
> > difference that started flaking, and I had to revert.
> > 
> > If you don't mind, I'll remove these 2 lines 237-238 in a follow-up CL that
> can
> > be easily reverted. Wdyt?
> 
> My concern is that these checks change the semantics of the start up state,
> relaxing the conditions for guest mode. If we can safely relax the conditions
> for guest sessions, why can't we also do the same for regular user sessions?

I've mixed two entirely different issues in this CL. I did a partial 'safe'
refactor of this guest business, but I should just do it right in another CL. So
this CL is now just focused on the screenshot business, and I'll have another CL
that removes the special treatment of guest mode.

https://codereview.chromium.org/288103005/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:252:
while not self._is_guest:
On 2014/05/15 23:42:18, Tim Song wrote:
> ditto.

Done.

[Tim Song, 2014-05-16 18:39:52]

Okay, LGTM.

[achuithb, 2014-05-16 18:43:04]

On 2014/05/16 18:39:52, Tim Song wrote:
> Okay, LGTM.

ty

[achuithb, 2014-05-16 19:35:27]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-05-16 19:36:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/288103005/40001

[commit-bot: I haz the power, 2014-05-16 19:37:59]

Change committed as 271083