tools/telemetry/telemetry/core/backends/chrome/oobe.py - Issue 288103005: Take a screenshot whenever login fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/oobe.py

Issue 288103005: Take a screenshot whenever login fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove partial guest refactoring Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/backends/chrome/oobe.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/oobe.py b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

index 520676301ec2a59d7709396e3bf7395f3aa5b1de..d19a7cc615737ccd9544dc890c95034f3f488a13 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/oobe.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

@@ -24,8 +24,7 @@ class Oobe(web_contents.WebContents):

def _ExecuteOobeApi(self, api, *args):

logging.info('Invoking %s' % api)

- util.WaitFor(lambda: self.EvaluateJavaScript(

- "typeof Oobe !== 'undefined'"), 10)

+ self.WaitForJavaScriptExpression("typeof Oobe == 'function'", 20)

if self.EvaluateJavaScript("typeof %s == 'undefined'" % api):

raise exceptions.LoginException('%s js api missing' % api)

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py ('k') | no next file » | no next file with comments »