net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem - Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem

Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)

Patch Set: review changes 2 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/parse_certificate_unittest/tbs_negative_serial_number.pem ('k') | net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem

diff --git a/net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem b/net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem

deleted file mode 100644

index efbf0533da48d85a56c5362ca9ce788dbedeae2e..0000000000000000000000000000000000000000

--- a/net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem

+++ /dev/null

@@ -1,24 +0,0 @@

-This is a TBSCertificate where the serial number is more than 20 octets (21

-octets, where first octet is a 0). This violates the rules in RFC 5280.

-$ openssl asn1parse -i < [TBS CERTIFICATE]

- 0:d=0 hl=2 l= 80 cons: SEQUENCE

- 2:d=1 hl=2 l= 3 cons: cont [ 0 ]

- 4:d=2 hl=2 l= 1 prim: INTEGER :00

- 7:d=1 hl=2 l= 21 prim: INTEGER :D8C37E4D87F9C8C82BAF26EF53501DF1FCF3A520

- 30:d=1 hl=2 l= 3 cons: SEQUENCE

- 32:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

- 35:d=1 hl=2 l= 3 cons: SEQUENCE

- 37:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

- 40:d=1 hl=2 l= 30 cons: SEQUENCE

- 42:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

- 57:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

- 72:d=1 hl=2 l= 3 cons: SEQUENCE

- 74:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

- 77:d=1 hl=2 l= 3 cons: SEQUENCE

- 79:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

------BEGIN TBS CERTIFICATE-----

-MFCgAwIBAAIVANjDfk2H+cjIK68m71NQHfH886UgMAMEAQEwAwQBBTAeFw0xMjEwMTgwMzEyMDB

-aFw0xMzEwMTgxNDU5NTlaMAMEAYMwAwQB8w==

------END TBS CERTIFICATE-----