net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem - Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem

Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)

Patch Set: review changes 2 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 This is a TBSCertificate where the serial number is more than 20 octets (21

2 octets, where first octet is a 0). This violates the rules in RFC 5280.

3

4

5 $ openssl asn1parse -i < [TBS CERTIFICATE]

6 0:d=0 hl=2 l= 80 cons: SEQUENCE

7 2:d=1 hl=2 l= 3 cons: cont [ 0 ]

8 4:d=2 hl=2 l= 1 prim: INTEGER :00

9 7:d=1 hl=2 l= 21 prim: INTEGER :D8C37E4D87F9C8C82BAF26EF53501DF 1FCF3A520

10 30:d=1 hl=2 l= 3 cons: SEQUENCE

11 32:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:01

12 35:d=1 hl=2 l= 3 cons: SEQUENCE

13 37:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:05

14 40:d=1 hl=2 l= 30 cons: SEQUENCE

15 42:d=2 hl=2 l= 13 prim: UTCTIME :121018031200Z

16 57:d=2 hl=2 l= 13 prim: UTCTIME :131018145959Z

17 72:d=1 hl=2 l= 3 cons: SEQUENCE

18 74:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:83

19 77:d=1 hl=2 l= 3 cons: SEQUENCE

20 79:d=2 hl=2 l= 1 prim: OCTET STRING [HEX DUMP]:F3

21 -----BEGIN TBS CERTIFICATE-----

22 MFCgAwIBAAIVANjDfk2H+cjIK68m71NQHfH886UgMAMEAQEwAwQBBTAeFw0xMjEwMTgwMzEyMDB

23 aFw0xMzEwMTgxNDU5NTlaMAMEAYMwAwQB8w==

24 -----END TBS CERTIFICATE-----

OLD	NEW