Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2880973002: memory-infra: skip IndexedDB file name in BACKGROUND dumps (Closed)

Created:
3 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 7 months ago
Reviewers:
jsbell, dmurph
CC:
chromium-reviews, jam, jsbell+idb_chromium.org, darin-cc_chromium.org, cmumford, erikchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: skip IndexedDB file name in BACKGROUND dumps Strings are not allowed in BACKGROUND dumps and suballocations are skipped anyways. Omitting it as the code is hitting a DCHECK. BUG=722052 Review-Url: https://codereview.chromium.org/2880973002 Cr-Commit-Position: refs/heads/master@{#471831} Committed: https://chromium.googlesource.com/chromium/src/+/a8b7cbcec01902e7b7f558e4816577e497828c33

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Primiano Tucci (use gerrit)
dmurph, PTAL, small 2 line change.
3 years, 7 months ago (2017-05-15 04:14:38 UTC) #4
jsbell
lgtm (an inline comment reflecting the details in the CL summary wouldn't be a bad ...
3 years, 7 months ago (2017-05-15 16:49:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880973002/20001
3 years, 7 months ago (2017-05-15 17:03:15 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:14:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8b7cbcec01902e7b7f558e48165...

Powered by Google App Engine
This is Rietveld 408576698