MHTMLGenerationManager - add param

Add a param to MHTMLGenerationManager

Add Page Problem Detectors variable to MHTMLGenerationParams
Also sets the variable when using the BackgroundLoadingOffliner.

Design Doc here: https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts

BUG=722638
Review-Url: https://codereview.chromium.org/2880963005
Cr-Commit-Position: refs/heads/master@{#472549}
Committed: https://chromium.googlesource.com/chromium/src/+/753970e38dce9e1bdb45fbf87abb668684f8de5d

[Pete Williamson, 2017-05-16 00:55:16]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 00:56:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:07:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pete Williamson, 2017-05-16 17:58:21]

petewil@chromium.org changed reviewers:
+ romax@chromium.org

[Pete Williamson, 2017-05-16 17:58:21]

We're adding a parameter to the MHTMLGenerationManager interface to specify when
we want to spend the extra effort to catch potential page problems when
offlining.

This change also adds a call to set the new parameter.

[Pete Williamson, 2017-05-16 17:58:55]

Description was changed from

==========
fixup


Add Page Problem Detectors variable to MHTMLGenerationParams

Also sets the variable when using the BackgroundLoadingOffliner.

BUG=722638
==========

to

==========
Add a param to MHTMLGenerationManager


Add Page Problem Detectors variable to MHTMLGenerationParams

Also sets the variable when using the BackgroundLoadingOffliner.

BUG=722638
==========

[romax, 2017-05-16 18:13:21]

lgtm

[Pete Williamson, 2017-05-16 18:20:12]

petewil@chromium.org changed reviewers:
+ creis@chromium.org

[Pete Williamson, 2017-05-16 18:20:12]

+CReis for mhtml_generation_params.h

[Dmitry Titov, 2017-05-16 18:26:15]

drive-by: Please add a link to a design document that details the plan on the
detectors, and explains the need for the additional bit.
I don't necessarily think it is a bad idea here, my point is that it is good in
general to have self-explaining CLs,
so that people who are not in the loop of discussion or will do 'code
archaeology' later can have all the info.

[Pete Williamson, 2017-05-16 19:40:59]

Description was changed from

==========
Add a param to MHTMLGenerationManager


Add Page Problem Detectors variable to MHTMLGenerationParams

Also sets the variable when using the BackgroundLoadingOffliner.

BUG=722638
==========

to

==========
Add a param to MHTMLGenerationManager

Add Page Problem Detectors variable to MHTMLGenerationParams
Also sets the variable when using the BackgroundLoadingOffliner.

Design Doc here:
https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts

BUG=722638
==========

[Pete Williamson, 2017-05-16 19:48:49]

On 2017/05/16 18:26:15, Dmitry Titov wrote:
> drive-by: Please add a link to a design document that details the plan on the
> detectors, and explains the need for the additional bit.
> I don't necessarily think it is a bad idea here, my point is that it is good
in
> general to have self-explaining CLs,
> so that people who are not in the loop of discussion or will do 'code
> archaeology' later can have all the info.

Added link to the design doc to the changelist description.

[Charlie Reis, 2017-05-16 20:48:20]

RS LGTM for content/

[Pete Williamson, 2017-05-16 20:53:56]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:55:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:51:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Pete Williamson, 2017-05-17 00:53:22]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 00:54:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:12:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:12:06]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Pete Williamson, 2017-05-17 16:47:12]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2017-05-17 16:47:12]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
romax@chromium.org
Link to the patchset: https://codereview.chromium.org/2880963005/#ps20001
(title: "Merged with tip of tree")

[commit-bot: I haz the power, 2017-05-17 16:47:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:25:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495039632501780,
"parent_rev": "6c04273ec0138fda36df82c84ff36293829002d9", "commit_rev":
"753970e38dce9e1bdb45fbf87abb668684f8de5d"}

[commit-bot: I haz the power, 2017-05-17 20:25:57]

Description was changed from

==========
Add a param to MHTMLGenerationManager

Add Page Problem Detectors variable to MHTMLGenerationParams
Also sets the variable when using the BackgroundLoadingOffliner.

Design Doc here:
https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts

BUG=722638
==========

to

==========
Add a param to MHTMLGenerationManager

Add Page Problem Detectors variable to MHTMLGenerationParams
Also sets the variable when using the BackgroundLoadingOffliner.

Design Doc here:
https://docs.google.com/document/d/1PWiu6PnLktkb-n-HgITR0EnEK6llKiJAJ9Xrk_2D6ts

BUG=722638

Review-Url: https://codereview.chromium.org/2880963005
Cr-Commit-Position: refs/heads/master@{#472549}
Committed:
https://chromium.googlesource.com/chromium/src/+/753970e38dce9e1bdb45fbf87abb...
==========

[commit-bot: I haz the power, 2017-05-17 20:25:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/753970e38dce9e1bdb45fbf87abb...