Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2880963004: Adjust error message and alert icon position (Closed)

Created:
3 years, 7 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust error message and alert icon position This will affect both new and old login UI: 1) The exclamation mark should have the same padding with the texts (i.e. body.chromeos .bubble). 2) The 'margin' of the bubble seems unnecessary but it make the position off a little bit, so it's removed. BUG=721978 Review-Url: https://codereview.chromium.org/2880963004 Cr-Commit-Position: refs/heads/master@{#474888} Committed: https://chromium.googlesource.com/chromium/src/+/37b5829be1daf71af6e35354c2f39a4eec37c60d

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change to unset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/login/bubble.css View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Wenzhao (Colin) Zang
alemate@ please take a look. Thanks so much.
3 years, 7 months ago (2017-05-15 20:04:30 UTC) #3
Wenzhao (Colin) Zang
On 2017/05/15 20:04:30, Wenzhao (Colin) Zang wrote: > alemate@ please take a look. Thanks so ...
3 years, 7 months ago (2017-05-19 06:44:06 UTC) #4
Alexander Alekseev
https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css File ui/login/bubble.css (left): https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14 ui/login/bubble.css:14: margin: 2px; This code is used on desktop version. ...
3 years, 7 months ago (2017-05-25 01:25:25 UTC) #5
Alexander Alekseev
https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css File ui/login/bubble.css (left): https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14 ui/login/bubble.css:14: margin: 2px; It is probably enough to put margin: ...
3 years, 7 months ago (2017-05-25 01:28:28 UTC) #6
Wenzhao (Colin) Zang
https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css File ui/login/bubble.css (left): https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14 ui/login/bubble.css:14: margin: 2px; On 2017/05/25 01:28:28, Alexander Alekseev wrote: > ...
3 years, 7 months ago (2017-05-25 02:27:56 UTC) #8
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-26 01:50:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880963004/40001
3 years, 7 months ago (2017-05-26 01:56:45 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 02:47:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/37b5829be1daf71af6e35354c2f3...

Powered by Google App Engine
This is Rietveld 408576698