Adjust error message and alert icon position

Adjust error message and alert icon position

This will affect both new and old login UI: 1) The exclamation mark should
have the same padding with the texts (i.e. body.chromeos .bubble). 2) The
'margin' of the bubble seems unnecessary but it make the position off a
little bit, so it's removed.

BUG=721978
Review-Url: https://codereview.chromium.org/2880963004
Cr-Commit-Position: refs/heads/master@{#474888}
Committed: https://chromium.googlesource.com/chromium/src/+/37b5829be1daf71af6e35354c2f39a4eec37c60d

[Wenzhao (Colin) Zang, 2017-05-15 20:03:32]

Description was changed from

==========
Adjust error message and alert icon position

BUG=721978
==========

to

==========
Adjust error message and alert icon position

This will affect both new and old login UI: 1) The exclamation mark should
have the same padding with the texts (i.e. body.chromeos .bubble). 2) The
'margin' of the bubble seems unnecessary but it make the position off a
little bit, so it's removed.

BUG=721978
==========

[Wenzhao (Colin) Zang, 2017-05-15 20:03:32]

wzang@chromium.org changed reviewers:
+ alemate@chromium.org

[Wenzhao (Colin) Zang, 2017-05-15 20:04:30]

alemate@ please take a look. Thanks so much.

[Wenzhao (Colin) Zang, 2017-05-19 06:44:06]

On 2017/05/15 20:04:30, Wenzhao (Colin) Zang wrote:
> alemate@ please take a look. Thanks so much.

alemate@ This will be shared by both old and new UI. It's very simple. Thanks so
much.

[Alexander Alekseev, 2017-05-25 01:25:25]

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css
File ui/login/bubble.css (left):

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14
ui/login/bubble.css:14: margin: 2px;
This code is used on desktop version.
Could you hide your changes behind body.chromeos selector as you did below?

[Alexander Alekseev, 2017-05-25 01:28:28]

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css
File ui/login/bubble.css (left):

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14
ui/login/bubble.css:14: margin: 2px;
It is probably enough to put

margin: unset;

to the block below.

[Wenzhao (Colin) Zang, 2017-05-25 02:25:23]

Patchset #2 (id:20001) has been deleted

[Wenzhao (Colin) Zang, 2017-05-25 02:27:56]

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css
File ui/login/bubble.css (left):

https://codereview.chromium.org/2880963004/diff/1/ui/login/bubble.css#oldcode14
ui/login/bubble.css:14: margin: 2px;
On 2017/05/25 01:28:28, Alexander Alekseev wrote:
> It is probably enough to put
> 
> margin: unset;
> 
> to the block below.

Done.

[Alexander Alekseev, 2017-05-26 01:50:22]

lgtm

[Wenzhao (Colin) Zang, 2017-05-26 01:55:52]

The CQ bit was checked by wzang@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:56:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 02:47:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495763752640640,
"parent_rev": "c4c1cb3507777d5bbef9bc09c87571fe4a768e41", "commit_rev":
"37b5829be1daf71af6e35354c2f39a4eec37c60d"}

[commit-bot: I haz the power, 2017-05-26 02:47:55]

Description was changed from

==========
Adjust error message and alert icon position

This will affect both new and old login UI: 1) The exclamation mark should
have the same padding with the texts (i.e. body.chromeos .bubble). 2) The
'margin' of the bubble seems unnecessary but it make the position off a
little bit, so it's removed.

BUG=721978
==========

to

==========
Adjust error message and alert icon position

This will affect both new and old login UI: 1) The exclamation mark should
have the same padding with the texts (i.e. body.chromeos .bubble). 2) The
'margin' of the bubble seems unnecessary but it make the position off a
little bit, so it's removed.

BUG=721978

Review-Url: https://codereview.chromium.org/2880963004
Cr-Commit-Position: refs/heads/master@{#474888}
Committed:
https://chromium.googlesource.com/chromium/src/+/37b5829be1daf71af6e35354c2f3...
==========

[commit-bot: I haz the power, 2017-05-26 02:47:56]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/37b5829be1daf71af6e35354c2f3...